Skip to content

Conversation

@yas-okadatech
Copy link

snakecase除去の前に、現在の状況でspecが通るようにしました。
また、spec実行用のCIを追加しました。

CIとSpecの修正は claudeが作成しました

@yas-okadatech yas-okadatech self-assigned this Jun 26, 2025
spec.require_paths = ["lib"]

spec.add_runtime_dependency "savon", ">= 2.3.0", '< 3.0.0'
spec.add_runtime_dependency "nori", "2.6.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新しいnoriが使われないように一時的にnoriを固定バージョンにしています

@kentoyoshida kentoyoshida requested a review from Copilot June 26, 2025 09:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the specs by updating XML namespace declarations and adjusts the corresponding test cases while also adding a new CI workflow to run RSpec tests.

  • Updated namespace declarations in fixture helpers and adjusted client spec tests
  • Added a new GitHub Actions workflow for running RSpec
  • Added a new runtime dependency in the gemspec

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
spec/support/fixture_helpers.rb Changed namespace declarations to new identifiers
spec/lib/client_spec.rb Adjusted test XML strings to use updated namespace identifiers
soapforce.gemspec Added 'nori' as a runtime dependency
.github/workflows/rspec.yml Introduced a CI workflow to run RSpec tests
Comments suppressed due to low confidence (2)

spec/lib/client_spec.rb:322

  • Verify that changing the namespace for the Id element from ins0 to ens is aligned with all related XML processing logic. This update should be reflected consistently in both the update and upsert test cases.
      @body = "<tns:update><tns:sObjects><ins0:type>Opportunity</ins0:type><ens:Id>003ABCDE</ens:Id><tns:Name>SOAPForce Opportunity</tns:Name><tns:CloseDate>2013-08-12</tns:CloseDate><tns:StageName>Closed Won</tns:StageName></tns:sObjects></tns:update>"

spec/support/fixture_helpers.rb:35

  • Ensure that the updated namespace identifiers (soap, fns, ens) are consistently utilized across all XML-based tests. Confirm that the mapping aligns with the expected XML structure in the application.
 xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/"

@primenumber-dev primenumber-dev deleted a comment from Copilot AI Jun 26, 2025
@yas-okadatech yas-okadatech merged commit fd99c2a into master Jun 27, 2025
1 check passed
@yas-okadatech yas-okadatech deleted the 34122-fix-spec branch June 27, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants