IO Parameters - FieldOutput (1/X) #800
Open
+564
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Created a new IO parameters file where all IO parameters will live. Currently, only the field output parameters have been written.
What is the current behavior? (You can also link to an open issue here)
Currently, parameters are declared in
InputFileReader, read inUserInputParameters, and packaged into their respective parameter subclasses. This is a bad way to do it because you have to edit and understand several files in order to add parameters. This makes is burdensome and more difficult to unit test individual parameter files. They are also interlinked, which adds to the issue.What is the new behavior (if this is a feature change)?
Now, each parameter class does five things.
This allows us to do the following things more easily
parameters.prmentirelyDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. These parameters are not used currently.
Other information:
Works on Add user input for the output compression level #671, Add a flag to choose what fields are saved to vtu #502, Add option to suppress output for specific fields #721,
UserInputParametersshould not be templated based on dimension #704, Let user specifiy output directory #673, Add unified parameter class interface #606, theuser_inputsfolder is a mess #572, Add in manual that the output file name can be used to change the output directory #147, write unit tests for the parameter validation functions #573,N_PER_DECADEDoxygen documentation unclear #259