Update voice_processing_audio_unit.mm by liufeigit · Pull Request #2 · pristineio/webrtc-mirror

liufeigit · 2016-06-17T04:46:32Z

kAudioOutputUnitProperty_SetInputCallback for kAudioUnitScope_Global bus is 0

id:20001 of https://codereview.webrtc.org/2061193002/ ) Reason for revert: Revert this because it broke the google3 import build. http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20google3%20Importer%20%28Shem%20TOT%29/builds/67/steps/blaze_regular_tests/logs/stdio Original issue's description: > Remove audio/video distinction for probe packets. > > Allows detecting large-enough audio packets as part of a probe, > speculative fix for a rampup-time regression in M50. These packets are > accounted on the send side when probing. > > BUG=webrtc:5985 > R=mflodman@webrtc.org, philipel@webrtc.org > > Committed: https://crrev.com/a7d88d38448f6a5677a017562765ab505b89d468 > Cr-Commit-Position: refs/heads/master@{#13210} TBR=mflodman@webrtc.org,philipel@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5985 Review-Url: https://codereview.webrtc.org/2086633002 Cr-Commit-Position: refs/heads/master@{#13221}

…id:1 of https://codereview.webrtc.org/2086633002/ ) Reason for revert: Fix already landed in google3, this revert actually breaks the import. Original issue's description: > Revert of Remove audio/video distinction for probe packets. (patchset #2 id:20001 of https://codereview.webrtc.org/2061193002/ ) > > Reason for revert: > Revert this because it broke the google3 import build. > http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20google3%20Importer%20%28Shem%20TOT%29/builds/67/steps/blaze_regular_tests/logs/stdio > > Original issue's description: > > Remove audio/video distinction for probe packets. > > > > Allows detecting large-enough audio packets as part of a probe, > > speculative fix for a rampup-time regression in M50. These packets are > > accounted on the send side when probing. > > > > BUG=webrtc:5985 > > R=mflodman@webrtc.org, philipel@webrtc.org > > > > Committed: https://crrev.com/a7d88d38448f6a5677a017562765ab505b89d468 > > Cr-Commit-Position: refs/heads/master@{#13210} > > TBR=mflodman@webrtc.org,philipel@webrtc.org,pbos@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5985 > > Committed: https://crrev.com/17bde8c96ee8b5a7e496a7dc98828b84f9756925 > Cr-Commit-Position: refs/heads/master@{#13221} TBR=mflodman@webrtc.org,philipel@webrtc.org,honghaiz@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5985 Review-Url: https://codereview.webrtc.org/2085653002 Cr-Commit-Position: refs/heads/master@{#13223}

…on-virtual. (patchset #2 id:40001 of https://codereview.webrtc.org/2107253002/ ) Reason for revert: Reverting all CLs related to moving the eventlog, as they break Chromium tests. Original issue's description: > Fix to make the start/stop functions for the Rtc Eventlog non-virtual. > > This is needed to prevent the Chromium import bot from breaking. > > BUG= > R=tommi@webrtc.org > > Committed: https://crrev.com/df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6 > Cr-Commit-Position: refs/heads/master@{#13324} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.webrtc.org/2111803002 Cr-Commit-Position: refs/heads/master@{#13339}

It causes an asan initialization-order-fiasco in trying to read the names of other globally constructed data: ==21449==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x7f6f297bc5e8 at pc 0x7f6f26b332a7 bp 0x7ffd479f8cb0 sp 0x7ffd479f8ca8 READ of size 8 at 0x7f6f297bc5e8 thread T0 #0 0x7f6f26b332a6 in name webrtc/base/flags.h:83:38 #1 0x7f6f26b332a6 in Lookup webrtc/base/flags.cc:133 #2 0x7f6f26b332a6 in rtc::FlagList::Register(rtc::Flag*) webrtc/base/flags.cc:260 #3 0x7f6f2529972b in __cxx_global_var_init.1 BUG= Review-Url: https://codereview.webrtc.org/2110963004 Cr-Commit-Position: refs/heads/master@{#13479}

#2 id:20001 of https://codereview.webrtc.org/2207463004/ ) Reason for revert: Breaks bots. See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%20%28dbg%29/builds/15490 Original issue's description: > GN: Create target for video_capture_tests on Linux. > > BUG=webrtc:6042 > > Committed: https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c > Cr-Commit-Position: refs/heads/master@{#13638} TBR=mflodman@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6042 Review-Url: https://codereview.webrtc.org/2217463002 Cr-Commit-Position: refs/heads/master@{#13640}

#1 id:1 of https://codereview.webrtc.org/2217463002/ ) Reason for revert: Fix issue. Original issue's description: > Revert of GN: Create target for video_capture_tests on Linux. (patchset #2 id:20001 of https://codereview.webrtc.org/2207463004/ ) > > Reason for revert: > Breaks bots. > See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%20%28dbg%29/builds/15490 > > Original issue's description: > > GN: Create target for video_capture_tests on Linux. > > > > BUG=webrtc:6042 > > > > Committed: https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c > > Cr-Commit-Position: refs/heads/master@{#13638} > > TBR=mflodman@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6042 > > Committed: https://crrev.com/41bce13482464741e916190b4e5ec3c628f606dd > Cr-Commit-Position: refs/heads/master@{#13640} TBR=mflodman@webrtc.org,guidou@webrtc.org BUG=webrtc:6042 Review-Url: https://codereview.webrtc.org/2211013002 Cr-Commit-Position: refs/heads/master@{#13641}

…id:20001 of https://codereview.webrtc.org/2235893003/ ) Reason for revert: Breaks downstream. Original issue's description: > Remove the old AndroidVideoCapturer stack code. > > This code is no longer needed. Apps should be using the new API introduced here: https://codereview.webrtc.org/2127893002/ > > Committed: https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d > Cr-Commit-Position: refs/heads/master@{#13950} TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.webrtc.org/2291583002 Cr-Commit-Position: refs/heads/master@{#13958}

…id:1 of https://codereview.webrtc.org/2291583002/ ) Reason for revert: Downstream apps should now be fixed. Original issue's description: > Revert of Remove the old AndroidVideoCapturer stack code. (patchset #2 id:20001 of https://codereview.webrtc.org/2235893003/ ) > > Reason for revert: > Breaks downstream. > > Original issue's description: > > Remove the old AndroidVideoCapturer stack code. > > > > This code is no longer needed. Apps should be using the new API introduced here: https://codereview.webrtc.org/2127893002/ > > > > Committed: https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d > > Cr-Commit-Position: refs/heads/master@{#13950} > > TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/e39f251dacf66e50153bcda615f06b7c59e5856b > Cr-Commit-Position: refs/heads/master@{#13958} TBR=magjed@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.webrtc.org/2298063003 Cr-Commit-Position: refs/heads/master@{#13988}

…ttps://codereview.webrtc.org/2299633002/ ) Reason for revert: Breaks chromium build Original issue's description: > Remove all reference to carbon api > > BUG=webrtc:6282 > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > Cr-Commit-Position: refs/heads/master@{#14080} TBR=magjed@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2316563002 Cr-Commit-Position: refs/heads/master@{#14081}

…50001 of https://codereview.webrtc.org/2310043002/ ) Reason for revert: Broke Chrome fyi bots. See, e.g., https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/6730/steps/compile/logs/stdio Use of GetTimeStamp must be eliminated in Chrome before relanding. Original issue's description: > Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2306953002/ ) > > Reason for revert: > Will reland after downstream projects are updated. > > Original issue's description: > > Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2305623002/ ) > > > > Reason for revert: > > Broke downstream project. > > > > Original issue's description: > > > Delete cricket::VideoFrame::GetTimeStamp. > > > > > > TBR=tkchin@webrtc.org # Trivial change to VideoRendererAdapter > > > BUG=webrtc:5682 > > > > > > Committed: https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 > > > Cr-Commit-Position: refs/heads/master@{#14037} > > > > TBR=perkj@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/bca69e87de5df290f728833a4b3d8af3ae5d88e6 > > Cr-Commit-Position: refs/heads/master@{#14038} > > TBR=perkj@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5682 > > Committed: https://crrev.com/fa1ba19c5c7c57c8d16fae1a5da51877770fd53e > Cr-Commit-Position: refs/heads/master@{#14089} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Review-Url: https://codereview.webrtc.org/2315703002 Cr-Commit-Position: refs/heads/master@{#14090}

… of https://codereview.webrtc.org/2315703002/ ) Reason for revert: Chrome has now been updated (cl https://codereview.chromium.org/2317673002/). Original issue's description: > Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #2 id:150001 of https://codereview.webrtc.org/2310043002/ ) > > Reason for revert: > Broke Chrome fyi bots. See, e.g., > > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/6730/steps/compile/logs/stdio > > Use of GetTimeStamp must be eliminated in Chrome before relanding. > > Original issue's description: > > Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2306953002/ ) > > > > Reason for revert: > > Will reland after downstream projects are updated. > > > > Original issue's description: > > > Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2305623002/ ) > > > > > > Reason for revert: > > > Broke downstream project. > > > > > > Original issue's description: > > > > Delete cricket::VideoFrame::GetTimeStamp. > > > > > > > > TBR=tkchin@webrtc.org # Trivial change to VideoRendererAdapter > > > > BUG=webrtc:5682 > > > > > > > > Committed: https://crrev.com/fd6c99e43137d01fa6c120f7160f7c2999d1d8a3 > > > > Cr-Commit-Position: refs/heads/master@{#14037} > > > > > > TBR=perkj@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5682 > > > > > > Committed: https://crrev.com/bca69e87de5df290f728833a4b3d8af3ae5d88e6 > > > Cr-Commit-Position: refs/heads/master@{#14038} > > > > TBR=perkj@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/fa1ba19c5c7c57c8d16fae1a5da51877770fd53e > > Cr-Commit-Position: refs/heads/master@{#14089} > > TBR=perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/92b2e0852fcbe7765926755ccee884db965b6231 > Cr-Commit-Position: refs/heads/master@{#14090} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Review-Url: https://codereview.webrtc.org/2316493003 Cr-Commit-Position: refs/heads/master@{#14093}

…://codereview.webrtc.org/2316563002/ ) Reason for revert: Chromium build issues have been resolved. Original issue's description: > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > Reason for revert: > Breaks chromium build > > Original issue's description: > > Remove all reference to carbon api > > > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > Cr-Commit-Position: refs/heads/master@{#14080} > > TBR=magjed@webrtc.org,mflodman@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6282 > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > Cr-Commit-Position: refs/heads/master@{#14081} TBR=magjed@webrtc.org,mflodman@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2321493002 Cr-Commit-Position: refs/heads/master@{#14125}

…001 of https://codereview.webrtc.org/2315633002/ ) Reason for revert: Broke all Chromium libFuzzer builds https://bugs.chromium.org/p/chromium/issues/detail?id=645069 Original issue's description: > Setting up an RTP input fuzzer for NetEq > > This CL introduces a new fuzzer target neteq_rtp_fuzzer that > manipulates the RTP header fields before inserting the packets into > NetEq. A few helper classes are also introduced. > > BUG=webrtc:5447 > NOTRY=True > > Committed: https://crrev.com/2d273f1e97cd5030ed1686f27ce1118291b66395 > Cr-Commit-Position: refs/heads/master@{#14103} TBR=ivoc@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5447 Review-Url: https://codereview.webrtc.org/2328483002 Cr-Commit-Position: refs/heads/master@{#14131}

…ttps://codereview.webrtc.org/2321493002/ ) Reason for revert: Still breaks Chromium mac compile: [4542/22193] CXX obj/third_party/webrtc/base/rtc_base/unixfilesystem.o FAILED: obj/third_party/webrtc/base/rtc_base/unixfilesystem.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/base/rtc_base/unixfilesystem.o.d -DLOGGING=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=280106-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DSRTP_RELATIVE_PATH -DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DNO_MAIN_THREAD_WRAPPING -I../../third_party/webrtc_overrides -I../../third_party/boringssl/src/include -I../.. -Igen -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/boringssl/src/include -Wno-uninitialized -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O2 -g1 -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../third_party/webrtc/base/unixfilesystem.cc -o obj/third_party/webrtc/base/rtc_base/unixfilesystem.o ../../third_party/webrtc/base/unixfilesystem.cc:375:11: error: variable has incomplete type 'FSRef' FSRef fr; ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:467:8: note: forward declaration of 'FSRef' struct FSRef; ^ ../../third_party/webrtc/base/unixfilesystem.cc:376:27: error: use of undeclared identifier 'kUserDomain' if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, ^ ../../third_party/webrtc/base/unixfilesystem.cc:376:40: error: use of undeclared identifier 'kApplicationSupportFolderType' if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, ^ ../../third_party/webrtc/base/unixfilesystem.cc:377:27: error: use of undeclared identifier 'kCreateFolder'; did you mean 'CreateFolder'? kCreateFolder, &fr)) ^~~~~~~~~~~~~ CreateFolder ../../third_party/webrtc/base/unixfilesystem.cc:92:22: note: 'CreateFolder' declared here bool UnixFilesystem::CreateFolder(const Pathname &path, mode_t mode) { Original issue's description: > Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2316563002/ ) > > Reason for revert: > Chromium build issues have been resolved. > > Original issue's description: > > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > > > Reason for revert: > > Breaks chromium build > > > > Original issue's description: > > > Remove all reference to carbon api > > > > > > BUG=webrtc:6282 > > > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > > Cr-Commit-Position: refs/heads/master@{#14080} > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > > Cr-Commit-Position: refs/heads/master@{#14081} > > TBR=magjed@webrtc.org,mflodman@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6282 > > Committed: https://crrev.com/a90879b64fd8db57c0274169311d6b51dd59f1a0 > Cr-Commit-Position: refs/heads/master@{#14125} TBR=mflodman@webrtc.org,kthelgason@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2317343003 Cr-Commit-Position: refs/heads/master@{#14133}

…id:20001 of https://codereview.webrtc.org/2312613003/ ) Reason for revert: Breaks webrtc_perf_tests on Windows, Mac and Linux (that test don't run on trybots): https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%5Blarge%20tests%5D/builds/8841/steps/webrtc_perf_tests/logs/stdio Example: [ RUN ] FullStackTest.ForemanCifWithoutPacketLossVp9 # Fatal error in ../../webrtc/video/video_quality_test.cc, line 1056 # last system error: 34 # Check failed: !params_.audio.enabled Original issue's description: > Separating video settings in VideoQualityTest. > > This is a simple refactoring of VideoQualityTest. It will help in adding audio related settings to VideoQualityTest. > > BUG= > > Committed: https://crrev.com/f07fb0013164bdb031dcc88dc83365a27643b2d9 > Cr-Commit-Position: refs/heads/master@{#14139} TBR=stefan@webrtc.org,minyue@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.webrtc.org/2325723002 Cr-Commit-Position: refs/heads/master@{#14142}

…://codereview.webrtc.org/2317343003/ ) Reason for revert: Build issues have now _really_ been fixed Original issue's description: > Revert of move all reference to carbon api (patchset #2 id:300001 of https://codereview.webrtc.org/2321493002/ ) > > Reason for revert: > Still breaks Chromium mac compile: > [4542/22193] CXX obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > FAILED: obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/base/rtc_base/unixfilesystem.o.d -DLOGGING=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=280106-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DSRTP_RELATIVE_PATH -DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DNO_MAIN_THREAD_WRAPPING -I../../third_party/webrtc_overrides -I../../third_party/boringssl/src/include -I../.. -Igen -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/boringssl/src/include -Wno-uninitialized -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O2 -g1 -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../third_party/webrtc/base/unixfilesystem.cc -o obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > ../../third_party/webrtc/base/unixfilesystem.cc:375:11: error: variable has incomplete type 'FSRef' > FSRef fr; > ^ > /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:467:8: note: forward declaration of 'FSRef' > struct FSRef; > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:27: error: use of undeclared identifier 'kUserDomain' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:40: error: use of undeclared identifier 'kApplicationSupportFolderType' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:377:27: error: use of undeclared identifier 'kCreateFolder'; did you mean 'CreateFolder'? > kCreateFolder, &fr)) > ^~~~~~~~~~~~~ > CreateFolder > ../../third_party/webrtc/base/unixfilesystem.cc:92:22: note: 'CreateFolder' declared here > bool UnixFilesystem::CreateFolder(const Pathname &path, mode_t mode) { > > Original issue's description: > > Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2316563002/ ) > > > > Reason for revert: > > Chromium build issues have been resolved. > > > > Original issue's description: > > > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > > > > > Reason for revert: > > > Breaks chromium build > > > > > > Original issue's description: > > > > Remove all reference to carbon api > > > > > > > > BUG=webrtc:6282 > > > > > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > > > Cr-Commit-Position: refs/heads/master@{#14080} > > > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:6282 > > > > > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > > > Cr-Commit-Position: refs/heads/master@{#14081} > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/a90879b64fd8db57c0274169311d6b51dd59f1a0 > > Cr-Commit-Position: refs/heads/master@{#14125} > > TBR=mflodman@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6282 > > Committed: https://crrev.com/4e0581f543b026cbc31c3b24cf65c7f51dcd6124 > Cr-Commit-Position: refs/heads/master@{#14133} TBR=mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2327573002 Cr-Commit-Position: refs/heads/master@{#14155}

… (patchset #2 id:140001 of https://codereview.webrtc.org/2342783003/ ) Reason for revert: I was too impatient; this made android builds fail instead. See https://build.chromium.org/p/client.webrtc/builders/Linux32%20ARM/builds/585/steps/compile/logs/stdio Original issue's description: > Reland of Update test code to use I420Buffer when writing pixel data. (patchset #1 id:1 of https://codereview.webrtc.org/2342123003/ ) > > Reason for revert: > Intending to fix problem and reland. > > Original issue's description: > > Revert of Update test code to use I420Buffer when writing pixel data. (patchset #5 id:80001 of https://codereview.webrtc.org/2333373007/ ) > > > > Reason for revert: > > Fails 64-bit windows builds, it turns out I missed some of the needed int/size_t casts. Example https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release > > > > Hope our windows try bots get back in working shape soon. > > > > Original issue's description: > > > Update test code to use I420Buffer when writing pixel data. > > > > > > VideoFrameBuffer and VideoFrame will become immutable. > > > > > > BUG=webrtc:5921 > > > R=magjed@webrtc.org, phoglund@webrtc.org > > > > > > Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d > > > Cr-Commit-Position: refs/heads/master@{#14249} > > > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5921 > > > > Committed: https://crrev.com/fbf14607267adf03d235273283ca452a1e564861 > > Cr-Commit-Position: refs/heads/master@{#14251} > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5921 > > Committed: https://crrev.com/d21534a8cfe636bbcf3d7bb151945590abc92b2a > Cr-Commit-Position: refs/heads/master@{#14258} TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5921 Review-Url: https://codereview.webrtc.org/2343083002 Cr-Commit-Position: refs/heads/master@{#14259}

…codereview.webrtc.org/2327893002/ ) Reason for revert: Import breakage has been fixed. Original issue's description: > Revert of Optimize Android NV12 capture (patchset #2 id:20001 of https://codereview.webrtc.org/2317443003/ ) > > Reason for revert: > Import breakage in g3. > > Original issue's description: > > Optimize Android NV12 capture > > > > This CL optimizes the Android capture NV12 -> I420 + scaling code. For > > example, when the input is 1280x720 and we adapt to 640x360, this CL: > > - Reduces conversion time from 3.37 ms to 1.46 ms. > > - Reduces memory footprint by 1 MB. > > > > BUG=webrtc:6319 > > > > Committed: https://crrev.com/36d38cbb153e19bdc3c62a750aba6889da40aac2 > > Cr-Commit-Position: refs/heads/master@{#14167} > > TBR=sakal@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6319 TBR=sakal@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6319 Review-Url: https://codereview.webrtc.org/2332213011 Cr-Commit-Position: refs/heads/master@{#14273}

…ad of one by one (patchset #2 id:20001 of https://codereview.webrtc.org/2342313002/ ) Reason for revert: Seems to have broken Chromium tests. Original issue's description: > AcmReceiver: Ask NetEq to delete all decoders at once instead of one by one > > It requires a new NetEq method, but it can no longer fail. And we no > longer need to use AcmReceiver::decoders_, which we're trying to > eliminate. > > BUG=webrtc:5801 > > Committed: https://crrev.com/f6232b43a176e1717354b671a0a52b887d70de59 > Cr-Commit-Position: refs/heads/master@{#14275} TBR=ossu@webrtc.org,henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5801 Review-Url: https://codereview.webrtc.org/2349973002 Cr-Commit-Position: refs/heads/master@{#14278}

… (patchset #1 id:1 of https://codereview.webrtc.org/2343083002/ ) Reason for revert: Will fix android build failure. Original issue's description: > Revert of Update test code to use I420Buffer when writing pixel data. (patchset #2 id:140001 of https://codereview.webrtc.org/2342783003/ ) > > Reason for revert: > I was too impatient; this made android builds fail instead. See https://build.chromium.org/p/client.webrtc/builders/Linux32%20ARM/builds/585/steps/compile/logs/stdio > > Original issue's description: > > Reland of Update test code to use I420Buffer when writing pixel data. (patchset #1 id:1 of https://codereview.webrtc.org/2342123003/ ) > > > > Reason for revert: > > Intending to fix problem and reland. > > > > Original issue's description: > > > Revert of Update test code to use I420Buffer when writing pixel data. (patchset #5 id:80001 of https://codereview.webrtc.org/2333373007/ ) > > > > > > Reason for revert: > > > Fails 64-bit windows builds, it turns out I missed some of the needed int/size_t casts. Example https://build.chromium.org/p/client.webrtc/waterfall?builder=Win64%20Release > > > > > > Hope our windows try bots get back in working shape soon. > > > > > > Original issue's description: > > > > Update test code to use I420Buffer when writing pixel data. > > > > > > > > VideoFrameBuffer and VideoFrame will become immutable. > > > > > > > > BUG=webrtc:5921 > > > > R=magjed@webrtc.org, phoglund@webrtc.org > > > > > > > > Committed: https://crrev.com/280ad1514e44bf6717e5871526dd4632f759eb3d > > > > Cr-Commit-Position: refs/heads/master@{#14249} > > > > > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5921 > > > > > > Committed: https://crrev.com/fbf14607267adf03d235273283ca452a1e564861 > > > Cr-Commit-Position: refs/heads/master@{#14251} > > > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5921 > > > > Committed: https://crrev.com/d21534a8cfe636bbcf3d7bb151945590abc92b2a > > Cr-Commit-Position: refs/heads/master@{#14258} > > TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5921 > > Committed: https://crrev.com/3011627142bccdd73fce9fec854abb1f6b02b5c1 > Cr-Commit-Position: refs/heads/master@{#14259} TBR=phoglund@webrtc.org,palmkvist@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true BUG=webrtc:5921 Review-Url: https://codereview.webrtc.org/2347863002 Cr-Commit-Position: refs/heads/master@{#14283}

…set #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) Reason for revert: Breaks internal project. Original issue's description: > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > The purpose is to make it clearer it is a mobile application. > > BUG=webrtc:6359 > NOPRESUBMIT=true > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > Cr-Commit-Position: refs/heads/master@{#14356} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6359 Review-Url: https://codereview.webrtc.org/2358133003 Cr-Commit-Position: refs/heads/master@{#14358}

…#1 id:1 of https://codereview.webrtc.org/2358133003/ ) Reason for revert: Internal project is updated. Original issue's description: > Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Rename AppRTCDemo on Android and iOS to AppRTCMobile > > > > The purpose is to make it clearer it is a mobile application. > > > > BUG=webrtc:6359 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a > > Cr-Commit-Position: refs/heads/master@{#14356} > > TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6359 > > Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1 > Cr-Commit-Position: refs/heads/master@{#14358} TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6359 Review URL: https://codereview.webrtc.org/2373443005 . Cr-Commit-Position: refs/heads/master@{#14391}

…s. (patchset #2 id:40001 of https://codereview.webrtc.org/2380923002/ ) Reason for revert: It caused some tests in p2ptransportchannel flaky. Original issue's description: > Replace RelayPort with TurnPort in p2ptransportchannel tests. > > Also remove the relay servers in the tests. > Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. > > BUG=None > R=deadbeef@webrtc.org > > Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f > Cr-Commit-Position: refs/heads/master@{#14441} TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2385563002 Cr-Commit-Position: refs/heads/master@{#14443}

…everywhere (patchset #2 id:20001 of https://codereview.webrtc.org/2384693002/ ) Reason for revert: This CL breaks FYI bots with a compile error. Sample error: jingle/glue/thread_wrapper.cc -o obj/jingle/jingle_glue/thread_wrapper.o In file included from ../../jingle/glue/thread_wrapper.cc:5: In file included from ../../jingle/glue/thread_wrapper.h:16: In file included from ../../base/message_loop/message_loop.h:17: In file included from ../../base/memory/ref_counted.h:19: ../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous DEFINE_CHECK_OP_IMPL(EQ, ==) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL' else return MakeCheckOpString(v1, v2, names); \ ^~~~~~~~~~~~~~~~~ ../../jingle/glue/thread_wrapper.cc:46:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<rtc::Thread *, jingle_glue::JingleThreadWrapper *>' requested here DCHECK_EQ(rtc::Thread::Current(), current()); ^ ../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ' #define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2) ^ ../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP' ::logging::Check##name##Impl((val1), (val2), \ ^ <scratch space>:102:1: note: expanded from here CheckEQImpl ^ ../../base/logging.h:555:14: note: candidate function [with t1 = rtc::Thread *, t2 = jingle_glue::JingleThreadWrapper *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ ../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = rtc::Thread *, t2 = jingle_glue::JingleThreadWrapper *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ In file included from ../../jingle/glue/thread_wrapper.cc:5: In file included from ../../jingle/glue/thread_wrapper.h:16: In file included from ../../base/message_loop/message_loop.h:17: In file included from ../../base/memory/ref_counted.h:19: ../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous DEFINE_CHECK_OP_IMPL(EQ, ==) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL' else return MakeCheckOpString(v1, v2, names); \ ^~~~~~~~~~~~~~~~~ ../../jingle/glue/thread_wrapper.cc:81:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<jingle_glue::JingleThreadWrapper *, jingle_glue::JingleThreadWrapper *>' requested here DCHECK_EQ(this, JingleThreadWrapper::current()); ^ ../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ' #define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2) ^ ../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP' ::logging::Check##name##Impl((val1), (val2), \ ^ <scratch space>:5:1: note: expanded from here CheckEQImpl ^ ../../base/logging.h:555:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = jingle_glue::JingleThreadWrapper *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ ../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = jingle_glue::JingleThreadWrapper *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ In file included from ../../jingle/glue/thread_wrapper.cc:5: In file included from ../../jingle/glue/thread_wrapper.h:16: In file included from ../../base/message_loop/message_loop.h:17: In file included from ../../base/memory/ref_counted.h:19: ../../base/logging.h:598:1: error: call to 'MakeCheckOpString' is ambiguous DEFINE_CHECK_OP_IMPL(EQ, ==) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:592:17: note: expanded from macro 'DEFINE_CHECK_OP_IMPL' else return MakeCheckOpString(v1, v2, names); \ ^~~~~~~~~~~~~~~~~ ../../jingle/glue/thread_wrapper.cc:82:3: note: in instantiation of function template specialization 'logging::CheckEQImpl<jingle_glue::JingleThreadWrapper *, rtc::Thread *>' requested here DCHECK_EQ(this, rtc::Thread::Current()); ^ ../../base/logging.h:748:31: note: expanded from macro 'DCHECK_EQ' #define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2) ^ ../../base/logging.h:721:18: note: expanded from macro 'DCHECK_OP' ::logging::Check##name##Impl((val1), (val2), \ ^ <scratch space>:12:1: note: expanded from here CheckEQImpl ^ ../../base/logging.h:555:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = rtc::Thread *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ ../../third_party/webrtc/base/checks.h:122:14: note: candidate function [with t1 = jingle_glue::JingleThreadWrapper *, t2 = rtc::Thread *] std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) { ^ 3 errors generated. Original issue's description: > Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere > > The former is always defined (by webrtc/base/checks.h) to either 0 or > 1, whereas the latter isn't necessarily defined. > > NOTRY=true > BUG=webrtc:6451 > > Committed: https://crrev.com/ab0b929321d37669165d5795268fa10a8c97ec5b > Cr-Commit-Position: refs/heads/master@{#14474} TBR=ossu@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6451 Review-Url: https://codereview.webrtc.org/2384083004 Cr-Commit-Position: refs/heads/master@{#14480}

…#2 id:20001 of https://codereview.webrtc.org/2368243002/ ) Reason for revert: This change broke a downstream application. Original issue's description: > Delete transformadapter.cc and transformadapter.h. > > BUG=webrtc:6424 > > Committed: https://crrev.com/2c3c3e27321e4b616bd1222857b2882befc485e3 > Cr-Commit-Position: refs/heads/master@{#14541} TBR=perkj@webrtc.org,pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2400443003 Cr-Commit-Position: refs/heads/master@{#14543}

… of https://codereview.webrtc.org/2371363003/ ) Reason for revert: This CL breaks internal dependencies. Original issue's description: > Delete webrtc::VideoFrame::CopyFrame. > > BUG=webrtc:5682 > > Committed: https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc > Cr-Commit-Position: refs/heads/master@{#14550} TBR=magjed@webrtc.org,tommi@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Review-Url: https://codereview.webrtc.org/2397943003 Cr-Commit-Position: refs/heads/master@{#14553}

…hset #2 id:100001 of https://codereview.webrtc.org/2389133002/ ) Reason for revert: Causes compile errors. https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/8646/steps/generate_build_files/logs/stdio Original issue's description: > Add support for component builds on Windows Swarming. > > Some runtime dependencies on MSVC were missing and had to be added to rtc_base_approved. > > BUG=chromium:497757 > NOTRY=True > > Committed: https://crrev.com/66d4ce93244d17eb52a409dde036fe9114937651 > Cr-Commit-Position: refs/heads/master@{#14562} TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497757 Review-Url: https://codereview.webrtc.org/2400953002 Cr-Commit-Position: refs/heads/master@{#14563}

…reamReceiver. (patchset #2 id:60001 of https://codereview.webrtc.org/2390823009/ ) Reason for revert: Speculative revert as it may be the cause of the DrMemory test failure: https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/5115 Original issue's description: > Add path for recovered packets from internal::Call to RtpStreamReceiver. > > When the FlexfecReceiver recovers media packets, it inserts these into > internal::Call, which then distributes them to the appropriate > VideoReceiveStream/RtpStreamReceiver. > > BUG=webrtc:5654 > > Committed: https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0 > Cr-Commit-Position: refs/heads/master@{#14642} TBR=stefan@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2427733002 Cr-Commit-Position: refs/heads/master@{#14652}

…reamReceiver. (patchset #1 id:1 of https://codereview.webrtc.org/2427733002/ ) Reason for revert: Flaky test has been fixed. Original issue's description: > Revert of Add path for recovered packets from internal::Call to RtpStreamReceiver. (patchset #2 id:60001 of https://codereview.webrtc.org/2390823009/ ) > > Reason for revert: > Speculative revert as it may be the cause of the DrMemory test failure: > https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/5115 > > Original issue's description: > > Add path for recovered packets from internal::Call to RtpStreamReceiver. > > > > When the FlexfecReceiver recovers media packets, it inserts these into > > internal::Call, which then distributes them to the appropriate > > VideoReceiveStream/RtpStreamReceiver. > > > > BUG=webrtc:5654 > > > > Committed: https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0 > > Cr-Commit-Position: refs/heads/master@{#14642} > > TBR=stefan@webrtc.org,brandtr@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5654 > > Committed: https://crrev.com/862d74d0176fa762b3c96cf20bd36f27e7001a47 > Cr-Commit-Position: refs/heads/master@{#14652} TBR=stefan@webrtc.org,honghaiz@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2428303004 Cr-Commit-Position: refs/heads/master@{#14677}

…ndroid/ (patchset #2 id:20001 of https://codereview.webrtc.org/2533573002/ ) Reason for revert: Breaks downstream code Original issue's description: > Move ADM specific Android files into modules/audio_device/android/ > > - Move helpers_android.* and jvm_android.* from modules/utility/. > > BUG=none > TBR=perkj@webrtc.org > > Committed: https://crrev.com/e8d8a2bb9704beffed0780c7e0f3a9ef050ae97e > Cr-Commit-Position: refs/heads/master@{#15253} TBR=henrika@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.webrtc.org/2531893002 Cr-Commit-Position: refs/heads/master@{#15254}

… buckets (patchset #2 id:20001 of https://codereview.webrtc.org/2547593002/ ) Reason for revert: Breaks down-stream dependencies. Original issue's description: > APM: Change 3 UMA metrics to fewer but linearly distributed buckets > > In this change WebRTC.Audio.ApmCaptureInputLevel{Average,Peak} are > changed to 64 buckets, while WebRTC.Audio.AgcLevel is changed to 50 > buckets. All three are changed to have linear spacing between buckets. > > Also, the metrics are renamed to avoid stats conflicts because of different bucket schemes: > - WebRTC.Audio.AgcLevel -> WebRTC.Audio.AgcSetLevel > - WebRTC.Audio.ApmCaptureInputLevelAverage -> WebRTC.Audio.ApmCaptureInputLevelAverageRms > - WebRTC.Audio.ApmCaptureInputLevelPeakRms -> WebRTC.Audio.ApmCaptureInputLevelPeakRms > > BUG=webrtc:6622 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > Committed: https://crrev.com/49715fe3be17d8579586d5bc954d626126d53415 > Cr-Commit-Position: refs/heads/master@{#15418} TBR=peah@webrtc.org,rkaplow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6622 Review-Url: https://codereview.webrtc.org/2548333002 Cr-Commit-Position: refs/heads/master@{#15420}

… buckets (patchset #1 id:1 of https://codereview.webrtc.org/2548333002/ ) Reason for revert: The downstream problem is now fixed, and this should be good to land again. Original issue's description: > Revert of APM: Change 3 UMA metrics to fewer but linearly distributed buckets (patchset #2 id:20001 of https://codereview.webrtc.org/2547593002/ ) > > Reason for revert: > Breaks down-stream dependencies. > > Original issue's description: > > APM: Change 3 UMA metrics to fewer but linearly distributed buckets > > > > In this change WebRTC.Audio.ApmCaptureInputLevel{Average,Peak} are > > changed to 64 buckets, while WebRTC.Audio.AgcLevel is changed to 50 > > buckets. All three are changed to have linear spacing between buckets. > > > > Also, the metrics are renamed to avoid stats conflicts because of different bucket schemes: > > - WebRTC.Audio.AgcLevel -> WebRTC.Audio.AgcSetLevel > > - WebRTC.Audio.ApmCaptureInputLevelAverage -> WebRTC.Audio.ApmCaptureInputLevelAverageRms > > - WebRTC.Audio.ApmCaptureInputLevelPeakRms -> WebRTC.Audio.ApmCaptureInputLevelPeakRms > > > > BUG=webrtc:6622 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > > > Committed: https://crrev.com/49715fe3be17d8579586d5bc954d626126d53415 > > Cr-Commit-Position: refs/heads/master@{#15418} > > TBR=peah@webrtc.org,rkaplow@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6622 > > Committed: https://crrev.com/63407a9b6ae6f3fc096e01d64e46c6d21d86b517 > Cr-Commit-Position: refs/heads/master@{#15420} TBR=peah@webrtc.org,rkaplow@chromium.org BUG=webrtc:6622 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.webrtc.org/2551863003 Cr-Commit-Position: refs/heads/master@{#15442}

…hip. (patchset #2 id:20001 of https://codereview.webrtc.org/2584553002/ ) Reason for revert: The new method doesn't work as intended. It can't pass ownership, because the StatsReports is a vector of raw pointers to StatReport objects owned by the StatsCollector. Original issue's description: > New method StatsObserver::OnCompleteReports, passing ownership. > > The new name, OnCompleteReports rather than OnComplete, is needed > because in C++ method lookup, overriding a method hides all otherwise > inherited methods with the same name, even if they have a different > signature. And here, the intention is that each subclass should > override one or the other of the two methods, and inherit the method it > doesn't override. > > This cl is a prerequisite for > https://codereview.webrtc.org/2567143003/, because the Chrome glue > code needs to retain the stats report after the OnComplete method has > returned. > > Currently, Chrome makes a copy of the stats mapping (which breaks when > changing ValuePtr from an rtc::linked_ptr to an std::unique_ptr). After > this cl, Chrome can be fixed to take ownership and no longer needs to > copy anything, unblocking cl 2567143003. > > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2584553002 > Cr-Commit-Position: refs/heads/master@{#15708} > Committed: https://chromium.googlesource.com/external/webrtc/+/b36ee8d498be2fa58fde3f3f3d69a74e4d3b817d TBR=solenberg@webrtc.org,magjed@webrtc.org,tkchin@webrtc.org,hbos@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2641783002 Cr-Commit-Position: refs/heads/master@{#16144}

…hset #2 id:230001 of https://codereview.webrtc.org/2642753002/ ) Reason for revert: Breaks tests downstream. Original issue's description: > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.chromium.org/2632123005/ ) > > Reason for revert: > Fix in this CL: https://codereview.chromium.org/2640793003/ > > Original issue's description: > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #7 id:120001 of https://codereview.chromium.org/2627463004/ ) > > > > Reason for revert: > > Breaks android bots. > > > > Original issue's description: > > > Make the new jitter buffer the default jitter buffer. > > > > > > This CL contains only the changes necessary to make the switch to the new jitter > > > buffer, clean up will be done in follow up CLs. > > > > > > In this CL: > > > - Removed the WebRTC-NewVideoJitterBuffer experiment and made the > > > new video jitter buffer the default one. > > > - Moved WebRTC.Video.KeyFramesReceivedInPermille and > > > WebRTC.Video.JitterBufferDelayInMs to the ReceiveStatisticsProxy. > > > > > > BUG=webrtc:5514 > > > > > > Review-Url: https://codereview.webrtc.org/2627463004 > > > Cr-Commit-Position: refs/heads/master@{#16114} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/0f0763d86d5d4e7f27e8dece02560e39c6da97d6 > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5514 > > > > Review-Url: https://codereview.webrtc.org/2632123005 > > Cr-Commit-Position: refs/heads/master@{#16117} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c08c191f7d206dc0de945185370d18f29d556931 > > TBR=stefan@webrtc.org,terelius@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5514 > > Review-Url: https://codereview.webrtc.org/2642753002 > Cr-Commit-Position: refs/heads/master@{#16149} > Committed: https://chromium.googlesource.com/external/webrtc/+/f20dd0014d1cfc8a2e859a9e177e7fe2b21274ca TBR=stefan@webrtc.org,terelius@webrtc.org,philipel@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2638423003 Cr-Commit-Position: refs/heads/master@{#16159}

…ngSSL/OpenSSL. (patchset #2 id:20001 of https://codereview.webrtc.org/2640513002/ ) Reason for revert: Broke chromium build, due to a config being removed. Will add it back and remove the dependency in a chromium CL. Original issue's description: > Removing #defines previously used for building without BoringSSL/OpenSSL. > > These defines don't work any more, so they only cause confusion: > > FEATURE_ENABLE_SSL > HAVE_OPENSSL_SSL_H > SSL_USE_OPENSSL > > BUG=webrtc:7025 > > Review-Url: https://codereview.webrtc.org/2640513002 > Cr-Commit-Position: refs/heads/master@{#16196} > Committed: https://chromium.googlesource.com/external/webrtc/+/eaa826c2ee0668cfb4a0dfb66f8d388b65da20f5 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7025 Review-Url: https://codereview.webrtc.org/2648003003 Cr-Commit-Position: refs/heads/master@{#16197}

…hset #1 id:1 of https://codereview.webrtc.org/2638423003/ ) Reason for revert: Bugfixes related to the new jitter buffer has landed. Original issue's description: > Revert of Make the new jitter buffer the default jitter buffer. (patchset #2 id:230001 of https://codereview.webrtc.org/2642753002/ ) > > Reason for revert: > Breaks tests downstream. > > Original issue's description: > > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.chromium.org/2632123005/ ) > > > > Reason for revert: > > Fix in this CL: https://codereview.chromium.org/2640793003/ > > > > Original issue's description: > > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #7 id:120001 of https://codereview.chromium.org/2627463004/ ) > > > > > > Reason for revert: > > > Breaks android bots. > > > > > > Original issue's description: > > > > Make the new jitter buffer the default jitter buffer. > > > > > > > > This CL contains only the changes necessary to make the switch to the new jitter > > > > buffer, clean up will be done in follow up CLs. > > > > > > > > In this CL: > > > > - Removed the WebRTC-NewVideoJitterBuffer experiment and made the > > > > new video jitter buffer the default one. > > > > - Moved WebRTC.Video.KeyFramesReceivedInPermille and > > > > WebRTC.Video.JitterBufferDelayInMs to the ReceiveStatisticsProxy. > > > > > > > > BUG=webrtc:5514 > > > > > > > > Review-Url: https://codereview.webrtc.org/2627463004 > > > > Cr-Commit-Position: refs/heads/master@{#16114} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/0f0763d86d5d4e7f27e8dece02560e39c6da97d6 > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5514 > > > > > > Review-Url: https://codereview.webrtc.org/2632123005 > > > Cr-Commit-Position: refs/heads/master@{#16117} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/c08c191f7d206dc0de945185370d18f29d556931 > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:5514 > > > > Review-Url: https://codereview.webrtc.org/2642753002 > > Cr-Commit-Position: refs/heads/master@{#16149} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f20dd0014d1cfc8a2e859a9e177e7fe2b21274ca > > TBR=stefan@webrtc.org,terelius@webrtc.org,philipel@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5514 > > Review-Url: https://codereview.webrtc.org/2638423003 > Cr-Commit-Position: refs/heads/master@{#16159} > Committed: https://chromium.googlesource.com/external/webrtc/+/04926b82641c426d764aa6e013e133db519129db TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2652043005 Cr-Commit-Position: refs/heads/master@{#16293}

…hset #2 id:290001 of https://codereview.chromium.org/2652043005/ ) Reason for revert: Breaks downstream bots Original issue's description: > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2638423003/ ) > > Reason for revert: > Bugfixes related to the new jitter buffer has landed. > > Original issue's description: > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #2 id:230001 of https://codereview.webrtc.org/2642753002/ ) > > > > Reason for revert: > > Breaks tests downstream. > > > > Original issue's description: > > > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.chromium.org/2632123005/ ) > > > > > > Reason for revert: > > > Fix in this CL: https://codereview.chromium.org/2640793003/ > > > > > > Original issue's description: > > > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #7 id:120001 of https://codereview.chromium.org/2627463004/ ) > > > > > > > > Reason for revert: > > > > Breaks android bots. > > > > > > > > Original issue's description: > > > > > Make the new jitter buffer the default jitter buffer. > > > > > > > > > > This CL contains only the changes necessary to make the switch to the new jitter > > > > > buffer, clean up will be done in follow up CLs. > > > > > > > > > > In this CL: > > > > > - Removed the WebRTC-NewVideoJitterBuffer experiment and made the > > > > > new video jitter buffer the default one. > > > > > - Moved WebRTC.Video.KeyFramesReceivedInPermille and > > > > > WebRTC.Video.JitterBufferDelayInMs to the ReceiveStatisticsProxy. > > > > > > > > > > BUG=webrtc:5514 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2627463004 > > > > > Cr-Commit-Position: refs/heads/master@{#16114} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/0f0763d86d5d4e7f27e8dece02560e39c6da97d6 > > > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=webrtc:5514 > > > > > > > > Review-Url: https://codereview.webrtc.org/2632123005 > > > > Cr-Commit-Position: refs/heads/master@{#16117} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/c08c191f7d206dc0de945185370d18f29d556931 > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=webrtc:5514 > > > > > > Review-Url: https://codereview.webrtc.org/2642753002 > > > Cr-Commit-Position: refs/heads/master@{#16149} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/f20dd0014d1cfc8a2e859a9e177e7fe2b21274ca > > > > TBR=stefan@webrtc.org,terelius@webrtc.org,philipel@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5514 > > > > Review-Url: https://codereview.webrtc.org/2638423003 > > Cr-Commit-Position: refs/heads/master@{#16159} > > Committed: https://chromium.googlesource.com/external/webrtc/+/04926b82641c426d764aa6e013e133db519129db > > TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5514 > > Review-Url: https://codereview.webrtc.org/2652043005 > Cr-Commit-Position: refs/heads/master@{#16293} > Committed: https://chromium.googlesource.com/external/webrtc/+/09d6ef00fc21b9f2c2c27e50e5e2952329ac4b4b TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2656983002 Cr-Commit-Position: refs/heads/master@{#16316}

…hset #2 id:260001 of https://codereview.chromium.org/2656983002/ ) Reason for revert: Incoming fix: https://codereview.chromium.org/2675693002/ Original issue's description: > Revert of Make the new jitter buffer the default jitter buffer. (patchset #2 id:290001 of https://codereview.chromium.org/2652043005/ ) > > Reason for revert: > Breaks downstream bots > > Original issue's description: > > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2638423003/ ) > > > > Reason for revert: > > Bugfixes related to the new jitter buffer has landed. > > > > Original issue's description: > > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #2 id:230001 of https://codereview.webrtc.org/2642753002/ ) > > > > > > Reason for revert: > > > Breaks tests downstream. > > > > > > Original issue's description: > > > > Reland of Make the new jitter buffer the default jitter buffer. (patchset #1 id:1 of https://codereview.chromium.org/2632123005/ ) > > > > > > > > Reason for revert: > > > > Fix in this CL: https://codereview.chromium.org/2640793003/ > > > > > > > > Original issue's description: > > > > > Revert of Make the new jitter buffer the default jitter buffer. (patchset #7 id:120001 of https://codereview.chromium.org/2627463004/ ) > > > > > > > > > > Reason for revert: > > > > > Breaks android bots. > > > > > > > > > > Original issue's description: > > > > > > Make the new jitter buffer the default jitter buffer. > > > > > > > > > > > > This CL contains only the changes necessary to make the switch to the new jitter > > > > > > buffer, clean up will be done in follow up CLs. > > > > > > > > > > > > In this CL: > > > > > > - Removed the WebRTC-NewVideoJitterBuffer experiment and made the > > > > > > new video jitter buffer the default one. > > > > > > - Moved WebRTC.Video.KeyFramesReceivedInPermille and > > > > > > WebRTC.Video.JitterBufferDelayInMs to the ReceiveStatisticsProxy. > > > > > > > > > > > > BUG=webrtc:5514 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2627463004 > > > > > > Cr-Commit-Position: refs/heads/master@{#16114} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/0f0763d86d5d4e7f27e8dece02560e39c6da97d6 > > > > > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:5514 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2632123005 > > > > > Cr-Commit-Position: refs/heads/master@{#16117} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/c08c191f7d206dc0de945185370d18f29d556931 > > > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > BUG=webrtc:5514 > > > > > > > > Review-Url: https://codereview.webrtc.org/2642753002 > > > > Cr-Commit-Position: refs/heads/master@{#16149} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/f20dd0014d1cfc8a2e859a9e177e7fe2b21274ca > > > > > > TBR=stefan@webrtc.org,terelius@webrtc.org,philipel@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5514 > > > > > > Review-Url: https://codereview.webrtc.org/2638423003 > > > Cr-Commit-Position: refs/heads/master@{#16159} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/04926b82641c426d764aa6e013e133db519129db > > > > TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:5514 > > > > Review-Url: https://codereview.webrtc.org/2652043005 > > Cr-Commit-Position: refs/heads/master@{#16293} > > Committed: https://chromium.googlesource.com/external/webrtc/+/09d6ef00fc21b9f2c2c27e50e5e2952329ac4b4b > > TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5514 > > Review-Url: https://codereview.webrtc.org/2656983002 > Cr-Commit-Position: refs/heads/master@{#16316} > Committed: https://chromium.googlesource.com/external/webrtc/+/27378f39ced81acb1c2a61808e5e42fcf65d4b8d TBR=stefan@webrtc.org,terelius@webrtc.org,kjellander@webrtc.org,kjellander@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2670183002 Cr-Commit-Position: refs/heads/master@{#16420}

…01 of https://codereview.webrtc.org/2680893002/ ) Reason for revert: Fix the problem. Original issue's description: > Revert of Add QP sum stats for received streams. (patchset #10 id:180001 of https://codereview.webrtc.org/2649133005/ ) > > Reason for revert: > Breaks downstream build. > > Original issue's description: > > Add QP sum stats for received streams. > > > > This is not implemented yet in any of the decoders. > > > > BUG=webrtc:6541 > > > > Review-Url: https://codereview.webrtc.org/2649133005 > > Cr-Commit-Position: refs/heads/master@{#16475} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ff0e72fd165facac27f0313aa178648782e63bc4 > > TBR=hta@webrtc.org,hbos@webrtc.org,sprang@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6541 > > Review-Url: https://codereview.webrtc.org/2680893002 . > Cr-Commit-Position: refs/heads/master@{#16480} > Committed: https://chromium.googlesource.com/external/webrtc/+/69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b TBR=hta@webrtc.org,hbos@webrtc.org,sprang@webrtc.org,magjed@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org BUG=webrtc:6541 Review-Url: https://codereview.webrtc.org/2681663005 Cr-Commit-Position: refs/heads/master@{#16511}

…r timestamps. (patchset #2 id:150001 of https://codereview.webrtc.org/2687073002/ ) Reason for revert: Reverting was done incorrectly. Returning patchset. Original issue's description: > Revert of Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. (patchset #5 id:80001 of https://codereview.webrtc.org/2668763004/ ) > > Reason for revert: > Speculative revert due to regression in perf tests. > > Original issue's description: > > Added VP8 simulcast tests. Fixed analyzer to correctly infer timestamps. > > > > > > BUG=webrtc:7095 > > > > Review-Url: https://codereview.webrtc.org/2668763004 > > Cr-Commit-Position: refs/heads/master@{#16428} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5f4712686550ba1d069c5e4c456ffcabe7ccba97 > > TBR=sprang@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2687073002 > Cr-Commit-Position: refs/heads/master@{#16510} > Committed: https://chromium.googlesource.com/external/webrtc/+/e67c59e7d2fce1fcdb013605f37344a802dfc9e5 TBR=sprang@webrtc.org,nisse@webrtc.org,mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2685583006 Cr-Commit-Position: refs/heads/master@{#16512}

…nvoker. (patchset #2 id:20001 of https://codereview.webrtc.org/2689233003/ ) Reason for revert: The change to messagequeue.h isn't backwards compatible. Will reland after making it backwards compatible. Original issue's description: > Use std::unique_ptr instead of rtc::scoped_refptr in AsyncInvoker. > > The AsyncClosures only ever have one thing referencing them, so they > should be using std::unique_ptr to manage ownership. Maybe this code was > written before std::unique_ptr was available. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2689233003 > Cr-Commit-Position: refs/heads/master@{#16680} > Committed: https://chromium.googlesource.com/external/webrtc/+/a5a472927bb209a053b2648d1f0b006f4c8c30ac TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2703613006 Cr-Commit-Position: refs/heads/master@{#16683}

id:70001 of https://codereview.webrtc.org/2718653002/ ) Reason for revert: Breaks AppRTCMobile in release configuration Original issue's description: > Reland of move some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2714123002/ ) > > Reason for revert: > Buildbot issues have been fixed. > > Original issue's description: > > Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ ) > > > > Reason for revert: > > Breaks buildbot > > > > Original issue's description: > > > Remove some warning suppressions from SocketRocket. > > > > > > These warnings started appearing on a clang update. This CL patches the > > > vendored library and removes the supression. We assert on the return as > > > we're not equipped to deal with failures there anyway. > > > > > > BUG=webrtc:6396 > > > NOTRY=true > > > > > > Review-Url: https://codereview.webrtc.org/2704383004 > > > Cr-Commit-Position: refs/heads/master@{#16820} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d > > > > TBR=kjellander@webrtc.org,magjed@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6396 > > > > Review-Url: https://codereview.webrtc.org/2714123002 > > Cr-Commit-Position: refs/heads/master@{#16822} > > Committed: https://chromium.googlesource.com/external/webrtc/+/e47de1a69c2f574d71728b16825f8cdbf7407481 > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6396 > > Review-Url: https://codereview.webrtc.org/2718653002 > Cr-Commit-Position: refs/heads/master@{#16823} > Committed: https://chromium.googlesource.com/external/webrtc/+/00df91ce50c71b7895ec24246c71c08568236967 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6396 Review-Url: https://codereview.webrtc.org/2718703002 Cr-Commit-Position: refs/heads/master@{#16829}

id:60001 of https://codereview.webrtc.org/2718703002/ ) Reason for revert: AppRTCMobile has been fixed. Original issue's description: > Revert of move some warning suppressions from SocketRocket. (patchset #2 id:70001 of https://codereview.webrtc.org/2718653002/ ) > > Reason for revert: > Breaks AppRTCMobile in release configuration > > Original issue's description: > > Reland of move some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2714123002/ ) > > > > Reason for revert: > > Buildbot issues have been fixed. > > > > Original issue's description: > > > Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ ) > > > > > > Reason for revert: > > > Breaks buildbot > > > > > > Original issue's description: > > > > Remove some warning suppressions from SocketRocket. > > > > > > > > These warnings started appearing on a clang update. This CL patches the > > > > vendored library and removes the supression. We assert on the return as > > > > we're not equipped to deal with failures there anyway. > > > > > > > > BUG=webrtc:6396 > > > > NOTRY=true > > > > > > > > Review-Url: https://codereview.webrtc.org/2704383004 > > > > Cr-Commit-Position: refs/heads/master@{#16820} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d > > > > > > TBR=kjellander@webrtc.org,magjed@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:6396 > > > > > > Review-Url: https://codereview.webrtc.org/2714123002 > > > Cr-Commit-Position: refs/heads/master@{#16822} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/e47de1a69c2f574d71728b16825f8cdbf7407481 > > > > TBR=kjellander@webrtc.org,magjed@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6396 > > > > Review-Url: https://codereview.webrtc.org/2718653002 > > Cr-Commit-Position: refs/heads/master@{#16823} > > Committed: https://chromium.googlesource.com/external/webrtc/+/00df91ce50c71b7895ec24246c71c08568236967 > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6396 > > Review-Url: https://codereview.webrtc.org/2718703002 > Cr-Commit-Position: refs/heads/master@{#16829} > Committed: https://chromium.googlesource.com/external/webrtc/+/0b34577625ef63d0dea9c72ac9972d111b359ff7 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6396 Review-Url: https://codereview.webrtc.org/2715943003 Cr-Commit-Position: refs/heads/master@{#16830}

…tchset #2 id:20001 of https://codereview.webrtc.org/2709153002/ ) Reason for revert: Looks like webrtc_perf_test started failing on linux, mac and windows after this cl landed. Example failure: https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/1386/steps/webrtc_perf_tests/logs/stdio [ RUN ] CallPerfTest.ReceivesCpuOveruseAndUnderuse ../../webrtc/call/call_perf_tests.cc:522: Failure Value of: Wait() Actual: false Expected: true Timed out before receiving an overuse callback. [ FAILED ] CallPerfTest.ReceivesCpuOveruseAndUnderuse (120056 ms) Original issue's description: > Set scaling limit at 320 * 180 for all implementations. > > The MediaCodec decoder on android has trouble decoding video at > so low resolutions. We set the limit a bit higher for all implementations > pending a robust software fallback implementation for MediaCodec. > > BUG=webrtc:7206 > > Review-Url: https://codereview.webrtc.org/2709153002 > Cr-Commit-Position: refs/heads/master@{#16798} > Committed: https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2 TBR=magjed@webrtc.org,sprang@webrtc.org,kthelgason@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7206 Review-Url: https://codereview.webrtc.org/2711913007 Cr-Commit-Position: refs/heads/master@{#16839}

…e (patchset #2 id:20001 of https://codereview.webrtc.org/2705163007/ ) Reason for revert: Looks like this caused the iOS API Framework Builder to fail. https://build.chromium.org/p/client.webrtc/builders/iOS%20API%20Framework%20Builder/builds/3487/steps/zip%20archive/logs/stdio Zipping /b/rr/tmpkIyP1e/w/webrtc_ios_api_framework.zip... Traceback (most recent call last): File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 144, in <module> sys.exit(main()) File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 130, in main exit_code = zip_with_subprocess(root, output, entries) File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 43, in zip_with_subprocess assert os.path.isdir(path), path AssertionError: /b/c/b/iOS_API_Framework_Builder/src/out_ios_libs/WebRTC.dSYM/ step returned non-zero exit code: 1 @@@STEP_FAILURE@@@ Original issue's description: > Do not produce dSYM file for the iOS Frameworks with bitcode > > Though dSYM files can be generated when building applications or libraries > with bitcode. They cannot be used to symbolicate crash reports from > applications. Instead, developers need to grab the real dSYM files, which > are generated for each specific device type after uploading an iOS / tvOS > application to App Store (or to a device using Xcode). Apple clearly warns > about it in its documentation: > > https://developer.apple.com/library/content/technotes/tn2151/_index.html#//apple_ref/doc/uid/DTS40008184-CH1-SYMBOLICATION-BITCODE > > With that in mind, I believe that it would be better to not confuse > developers by giving them dSYM files that are not very helpful with > the bitcode-enabled framework. Thus, proposing the following modification > to the building script, to generate dSYM by default only without > the bitcode option. However, if some developers still want to get > the dSYM files as a build-process artifact, when enabling bitcode, > they can explicitly add --extra-gn-args enable_dsyms=true to the script. > > Let me know if it lgty. > > NOTRY=True > BUG=None > > Review-Url: https://codereview.webrtc.org/2705163007 > Cr-Commit-Position: refs/heads/master@{#16836} > Committed: https://chromium.googlesource.com/external/webrtc/+/d74517c52a6cd4172b1f3fdc4e624b6145ff5a0f TBR=kjellander@webrtc.org,kthelgason@webrtc.org,VladimirTechMan@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2719773002 Cr-Commit-Position: refs/heads/master@{#16844}

…tchset #1 id:1 of https://codereview.webrtc.org/2711913007/ ) Reason for revert: Reland after fixing broken perf tests. Original issue's description: > Revert of Set scaling limit at 320 * 180 for all implementations. (patchset #2 id:20001 of https://codereview.webrtc.org/2709153002/ ) > > Reason for revert: > Looks like webrtc_perf_test started failing on linux, mac and windows after this cl landed. > > Example failure: > > https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/1386/steps/webrtc_perf_tests/logs/stdio > > [ RUN ] CallPerfTest.ReceivesCpuOveruseAndUnderuse > ../../webrtc/call/call_perf_tests.cc:522: Failure > Value of: Wait() > Actual: false > Expected: true > Timed out before receiving an overuse callback. > [ FAILED ] CallPerfTest.ReceivesCpuOveruseAndUnderuse (120056 ms) > > > Original issue's description: > > Set scaling limit at 320 * 180 for all implementations. > > > > The MediaCodec decoder on android has trouble decoding video at > > so low resolutions. We set the limit a bit higher for all implementations > > pending a robust software fallback implementation for MediaCodec. > > > > BUG=webrtc:7206 > > > > Review-Url: https://codereview.webrtc.org/2709153002 > > Cr-Commit-Position: refs/heads/master@{#16798} > > Committed: https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2 > > TBR=magjed@webrtc.org,sprang@webrtc.org,kthelgason@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7206 > > Review-Url: https://codereview.webrtc.org/2711913007 > Cr-Commit-Position: refs/heads/master@{#16839} > Committed: https://chromium.googlesource.com/external/webrtc/+/37510bf0946afef1015eabb66a801af3ac30042a TBR=magjed@webrtc.org,sprang@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7206 Review-Url: https://codereview.webrtc.org/2718013002 Cr-Commit-Position: refs/heads/master@{#16853}

…set #7 id:240001 of https://codereview.webrtc.org/2513063003/ ) Reason for revert: This CL breaks iOS AppRTCMobile. We don't have any automatic tests running on the bots yet, so please try AppRTCMobile locally before relanding. Stack trace: * thread #15: tid = 0x20e933, 0x0000000100488440 AppRTCMobile`webrtc::AudioRtpReceiver::OnFirstPacketReceived(this=0x0000000170156c60, channel=0x000000010511a600) + 48 at rtpreceiver.cc:133, name = 'Thread 0x0x10421b2a0', stop reason = EXC_BAD_ACCESS (code=1, address=0x1a1aac71979) * frame #0: 0x0000000100488440 AppRTCMobile`webrtc::AudioRtpReceiver::OnFirstPacketReceived(this=0x0000000170156c60, channel=0x000000010511a600) + 48 at rtpreceiver.cc:133 frame #1: 0x000000010048a3f8 AppRTCMobile`void sigslot::_opaque_connection::emitter<webrtc::AudioRtpReceiver, cricket::BaseChannel*>(self=0x000000017424b380, args=0x000000010511a600) + 184 at sigslot.h:391 frame #2: 0x00000001005a30ec AppRTCMobile`void sigslot::_opaque_connection::emit<cricket::BaseChannel*>(this=0x000000017424b380, args=0x000000010511a600) const + 56 at sigslot.h:381 frame #3: 0x00000001005a3094 AppRTCMobile`sigslot::signal_with_thread_policy<sigslot::single_threaded, cricket::BaseChannel*>::emit(this=0x000000010511a678, args=0x000000010511a600) + 504 at sigslot.h:615 frame #4: 0x000000010057ef5c AppRTCMobile`sigslot::signal_with_thread_policy<sigslot::single_threaded, cricket::BaseChannel*>::operator(this=0x000000010511a678, args=0x000000010511a600)(cricket::BaseChannel*) + 32 at sigslot.h:621 frame #5: 0x000000010057ef00 AppRTCMobile`cricket::BaseChannel::OnMessage(this=0x000000010511a600, pmsg=0x000000016e676db0) + 600 at channel.cc:1494 frame #6: 0x0000000100584a58 AppRTCMobile`cricket::VoiceChannel::OnMessage(this=0x000000010511a600, pmsg=0x000000016e676db0) + 152 at channel.cc:1909 frame #7: 0x000000010017c0dc AppRTCMobile`rtc::MessageQueue::Dispatch(this=0x000000010421b2a0, pmsg=0x000000016e676db0) + 336 at messagequeue.cc:538 frame #8: 0x00000001001d8efc AppRTCMobile`rtc::Thread::ProcessMessages(this=0x000000010421b2a0, cmsLoop=-1) + 228 at thread.cc:496 frame #9: 0x00000001001d8e08 AppRTCMobile`rtc::Thread::Run(this=0x000000010421b2a0) + 28 at thread.cc:327 frame #10: 0x00000001001d8b0c AppRTCMobile`rtc::Thread::PreRun(pv=0x000000017000f030) + 300 at thread.cc:316 frame #11: 0x00000001843f1850 libsystem_pthread.dylib`_pthread_body + 240 frame #12: 0x00000001843f1760 libsystem_pthread.dylib`_pthread_start + 284 frame #13: 0x00000001843eed94 libsystem_pthread.dylib`thread_start + 4 Original issue's description: > Add the OnAddTrack callback for Objective-C wrapper. > > Created an Obj-C wrapper for the callback OnAddTrack in this CL since it has been added to native C++ API > The callback function is called when a track is signaled by remote side and a new RtpReceiver is created. > The application can tell when tracks are added to the streams by listening to this callback. > > BUG=webrtc:6112 > > Review-Url: https://codereview.webrtc.org/2513063003 > Cr-Commit-Position: refs/heads/master@{#16835} > Committed: https://chromium.googlesource.com/external/webrtc/+/633f6fe0046131ed815098298b9a3120bac1d7a0 TBR=tkchin@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6112 Review-Url: https://codereview.webrtc.org/2720753002 Cr-Commit-Position: refs/heads/master@{#16871}

…e (patchset #1 id:1 of https://codereview.webrtc.org/2719773002/ ) Reason for revert: Fixing issues with the framework builder. Original issue's description: > Revert of Do not produce dSYM file for the iOS Frameworks with bitcode (patchset #2 id:20001 of https://codereview.webrtc.org/2705163007/ ) > > Reason for revert: > Looks like this caused the iOS API Framework Builder to fail. > > https://build.chromium.org/p/client.webrtc/builders/iOS%20API%20Framework%20Builder/builds/3487/steps/zip%20archive/logs/stdio > > Zipping /b/rr/tmpkIyP1e/w/webrtc_ios_api_framework.zip... > Traceback (most recent call last): > File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 144, in <module> > sys.exit(main()) > File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 130, in main > exit_code = zip_with_subprocess(root, output, entries) > File "/b/rr/tmpkIyP1e/rw/checkout/scripts/slave/recipe_modules/zip/resources/zip.py", line 43, in zip_with_subprocess > assert os.path.isdir(path), path > AssertionError: /b/c/b/iOS_API_Framework_Builder/src/out_ios_libs/WebRTC.dSYM/ > step returned non-zero exit code: 1 > @@@STEP_FAILURE@@@ > > Original issue's description: > > Do not produce dSYM file for the iOS Frameworks with bitcode > > > > Though dSYM files can be generated when building applications or libraries > > with bitcode. They cannot be used to symbolicate crash reports from > > applications. Instead, developers need to grab the real dSYM files, which > > are generated for each specific device type after uploading an iOS / tvOS > > application to App Store (or to a device using Xcode). Apple clearly warns > > about it in its documentation: > > > > https://developer.apple.com/library/content/technotes/tn2151/_index.html#//apple_ref/doc/uid/DTS40008184-CH1-SYMBOLICATION-BITCODE > > > > With that in mind, I believe that it would be better to not confuse > > developers by giving them dSYM files that are not very helpful with > > the bitcode-enabled framework. Thus, proposing the following modification > > to the building script, to generate dSYM by default only without > > the bitcode option. However, if some developers still want to get > > the dSYM files as a build-process artifact, when enabling bitcode, > > they can explicitly add --extra-gn-args enable_dsyms=true to the script. > > > > Let me know if it lgty. > > > > NOTRY=True > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2705163007 > > Cr-Commit-Position: refs/heads/master@{#16836} > > Committed: https://chromium.googlesource.com/external/webrtc/+/d74517c52a6cd4172b1f3fdc4e624b6145ff5a0f > > TBR=kjellander@webrtc.org,kthelgason@webrtc.org,VladimirTechMan@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=None > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2719773002 > Cr-Commit-Position: refs/heads/master@{#16844} > Committed: https://chromium.googlesource.com/external/webrtc/+/da00077cfac335503b3335d5eac110f2f5bff408 TBR=kjellander@webrtc.org,vladimirtechman@gmail.com,tommi@webrtc.org NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2718983002 Cr-Commit-Position: refs/heads/master@{#16924}

…lse (patchset #2 id:20001 of https://codereview.webrtc.org/2725053008/ ) Reason for revert: Fails Chromium builds: b/c/b/linux/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/webrtc/api/BUILD.gn:186:5: Can't load input file. "//webrtc/test:test_support", ^------------------------- Original issue's description: > GN: Include webrtc/api targets even if rtc_include_tests=false > > The main purpose with the rtc_include_tests GN variable is to avoid > generating and compiling all the test targets. > Some of our examples have dependencies on the test headers in API, > so therefore this change is relaxing that condition. > > BUG=webrtc:6828 > NOTRY=True > TBR=ehmaldonado@webrtc.org, > > Review-Url: https://codereview.webrtc.org/2725053008 > Cr-Commit-Position: refs/heads/master@{#16989} > Committed: https://chromium.googlesource.com/external/webrtc/+/a769ceba656eff1d12df82ef3058306cf948b215 TBR=ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2728073002 Cr-Commit-Position: refs/heads/master@{#16990}

…hset #2 id:20001 of https://codereview.webrtc.org/2728103002/ ) Reason for revert: Fails on tsan http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/10235 Original issue's description: > Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo > Add extra checks to it to simplify diagnostic should it fail again. > > BUG=webrtc:7292 > > Review-Url: https://codereview.webrtc.org/2728103002 > Cr-Commit-Position: refs/heads/master@{#16999} > Committed: https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b TBR=asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7292 Review-Url: https://codereview.webrtc.org/2730893002 Cr-Commit-Position: refs/heads/master@{#17000}

…hset #1 id:1 of https://codereview.webrtc.org/2730893002/ ) Reason for revert: Fixing race and relanding Original issue's description: > Revert of Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo (patchset #2 id:20001 of https://codereview.webrtc.org/2728103002/ ) > > Reason for revert: > Fails on tsan > http://build.chromium.org/p/client.webrtc/builders/Linux%20Tsan%20v2/builds/10235 > > Original issue's description: > > Fix flaky EndToEndTest.TransportSeqNumOnAudioAndVideo > > Add extra checks to it to simplify diagnostic should it fail again. > > > > BUG=webrtc:7292 > > > > Review-Url: https://codereview.webrtc.org/2728103002 > > Cr-Commit-Position: refs/heads/master@{#16999} > > Committed: https://chromium.googlesource.com/external/webrtc/+/bcb6004a9d53615a6428e070cbc6d52a2d8e833b > > TBR=asapersson@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7292 > > Review-Url: https://codereview.webrtc.org/2730893002 > Cr-Commit-Position: refs/heads/master@{#17000} > Committed: https://chromium.googlesource.com/external/webrtc/+/9a59473f2c403827a3560944c7ffe76d37ab77b9 TBR=asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7292 Review-Url: https://codereview.webrtc.org/2730673004 Cr-Commit-Position: refs/heads/master@{#17006}

id:20001 of https://codereview.webrtc.org/2722423003/ ) Reason for revert: Breaks compilation in FYI bots, e.g. here: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/9314 FAILED: obj/third_party/webrtc/pc/rtc_pc/channel.obj ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/pc/rtc_pc/channel.obj.rsp /c ../../third_party/webrtc/pc/channel.cc /Foobj/third_party/webrtc/pc/rtc_pc/channel.obj /Fd"obj/third_party/webrtc/pc/rtc_pc_cc.pdb" e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2819: type 'cricket::SrtpFilter' does not have an overloaded member 'operator ->' e:\b\c\b\win_builder\src\third_party\webrtc\pc\srtpfilter.h(45): note: see declaration of 'cricket::SrtpFilter' e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): note: did you intend to use '.' instead? e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2232: '->cricket::SrtpFilter::EnableExternalAuth': left operand has 'class' type, use '.' Original issue's description: > Improve testing of SRTP external auth code paths. > > Previously code behind ENABLE_EXTERNAL_AUTH was only compiled with Chromium > but developed in WebRTC, which made testing rather complicated. This caused > some trouble in the past (e.g. https://crbug.com/628400#c1) > > This CL helps in that the external auth code is now compiled with WebRTC > and the srtpfilter integration gets tested. > > BUG=chromium:628400 > > Review-Url: https://codereview.webrtc.org/2722423003 > Cr-Commit-Position: refs/heads/master@{#17030} > Committed: https://chromium.googlesource.com/external/webrtc/+/ac170d5c214e1f487ba82b888e5c3d5000118de0 TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:628400 Review-Url: https://codereview.webrtc.org/2734643002 Cr-Commit-Position: refs/heads/master@{#17031}

… of https://codereview.webrtc.org/2622923002/ ) Reason for revert: I had missed updating a few of Chrome's #includes, breaking the build. Original issue's description: > Delete unused TaskRunner abstraction. > > This is the fifth and final step in the process started in cl https://codereview.webrtc.org/2696703009/ > > Depends on the landing of a copy of this code in Chrome (step 4), cl > https://codereview.chromium.org/2694903005/ > > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2622923002 > Cr-Commit-Position: refs/heads/master@{#17107} > Committed: https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48b7460cb2308e7a2 TBR=pthatcher@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2732363004 Cr-Commit-Position: refs/heads/master@{#17109}

…ttps://codereview.webrtc.org/2732363004/ ) Reason for revert: Chrome includes now updated, see cl https://codereview.chromium.org/2737133002/ Original issue's description: > Revert of Delete unused TaskRunner abstraction. (patchset #2 id:20001 of https://codereview.webrtc.org/2622923002/ ) > > Reason for revert: > I had missed updating a few of Chrome's #includes, breaking the build. > > Original issue's description: > > Delete unused TaskRunner abstraction. > > > > This is the fifth and final step in the process started in cl https://codereview.webrtc.org/2696703009/ > > > > Depends on the landing of a copy of this code in Chrome (step 4), cl > > https://codereview.chromium.org/2694903005/ > > > > BUG=webrtc:6424 > > > > Review-Url: https://codereview.webrtc.org/2622923002 > > Cr-Commit-Position: refs/heads/master@{#17107} > > Committed: https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48b7460cb2308e7a2 > > TBR=pthatcher@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2732363004 > Cr-Commit-Position: refs/heads/master@{#17109} > Committed: https://chromium.googlesource.com/external/webrtc/+/9900be313c212c276377d406585b706079f8bc41 TBR=pthatcher@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2740063002 Cr-Commit-Position: refs/heads/master@{#17131}

…f EventTimeWrapper (patchset #2 id:70001 of https://codereview.webrtc.org/2745583006/ ) Reason for revert: Causes problems with TSAN: https://bugs.chromium.org/p/webrtc/issues/detail?id=7325 Original issue's description: > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper. > > Fix CallPerfTest.ReceivesCpuOveruseAndUnderuse to not fail on Android with new FrameGeneratorCapturer. > > BUG=webrtc:7301 > > Review-Url: https://codereview.webrtc.org/2745583006 > Cr-Commit-Position: refs/heads/master@{#17168} > Committed: https://chromium.googlesource.com/external/webrtc/+/b00742508ae9320ce86ad2963c18443a83976999 TBR=stefan@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7301 Review-Url: https://codereview.webrtc.org/2743993002 Cr-Commit-Position: refs/heads/master@{#17173}

…f EventTimeWrapper (patchset #2 id:90001 of https://codereview.webrtc.org/2744003002/ ) Reason for revert: CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL. It requires very accurate frame rate, which may not be so accurate now. Original issue's description: > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ ) > > And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/) > TBR=stefan@webrtc.org,tommi@webrtc.org > BUG=webrtc:7301,webrtc:7325 > > Review-Url: https://codereview.webrtc.org/2744003002 > Cr-Commit-Position: refs/heads/master@{#17196} > Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7301,webrtc:7325 Review-Url: https://codereview.webrtc.org/2748643002 Cr-Commit-Position: refs/heads/master@{#17198}

…EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/ ) Reason for revert: Reland with fixes to the failing perf tests. Original issue's description: > Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #2 id:90001 of https://codereview.webrtc.org/2744003002/ ) > > Reason for revert: > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL. It requires very accurate frame rate, which may not be so accurate now. > > Original issue's description: > > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ ) > > > > And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/) > > TBR=stefan@webrtc.org,tommi@webrtc.org > > BUG=webrtc:7301,webrtc:7325 > > > > Review-Url: https://codereview.webrtc.org/2744003002 > > Cr-Commit-Position: refs/heads/master@{#17196} > > Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f > > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7301,webrtc:7325 > > Review-Url: https://codereview.webrtc.org/2748643002 > Cr-Commit-Position: refs/heads/master@{#17198} > Committed: https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb30712cefe2639f88 BUG=webrtc:7301,webrtc:7325 Review-Url: https://codereview.webrtc.org/2750473002 Cr-Commit-Position: refs/heads/master@{#17253}

… speech generation. (patchset #2 id:100001 of https://codereview.webrtc.org/2740063004/ ) Reason for revert: Even if the conversational speech tool is external and not a core part of webrtc, there are too many trybots failing. Original issue's description: > C++ porting of the initial python script for conversational speech generation. > > This CL removes the Python script and adds its C++ porting. > The former was in its early stage and it has permanently been removed. > > BUG=webrtc:7218 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2740063004 > Cr-Commit-Position: refs/heads/master@{#17254} > Committed: https://chromium.googlesource.com/external/webrtc/+/0cf3aa6d0d170365a2dedb57960fbface736f851 TBR=henrik.lundin@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2753843002 Cr-Commit-Position: refs/heads/master@{#17257}

…EventTimeWrapper (patchset #11 id:300001 of https://codereview.webrtc.org/2750473002/ ) Reason for revert: Changes to frame-generator resulted in reduced fps on android and Mac on all tests. Original issue's description: > Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/ ) > > Reason for revert: > Reland with fixes to the failing perf tests. > > Original issue's description: > > Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #2 id:90001 of https://codereview.webrtc.org/2744003002/ ) > > > > Reason for revert: > > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL. It requires very accurate frame rate, which may not be so accurate now. > > > > Original issue's description: > > > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ ) > > > > > > And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/) > > > TBR=stefan@webrtc.org,tommi@webrtc.org > > > BUG=webrtc:7301,webrtc:7325 > > > > > > Review-Url: https://codereview.webrtc.org/2744003002 > > > Cr-Commit-Position: refs/heads/master@{#17196} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f > > > > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:7301,webrtc:7325 > > > > Review-Url: https://codereview.webrtc.org/2748643002 > > Cr-Commit-Position: refs/heads/master@{#17198} > > Committed: https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb30712cefe2639f88 > > BUG=webrtc:7301,webrtc:7325 > > Review-Url: https://codereview.webrtc.org/2750473002 > Cr-Commit-Position: refs/heads/master@{#17253} > Committed: https://chromium.googlesource.com/external/webrtc/+/2549ad4fef419a055671c5be39fcfa27ba573c3b TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7301,webrtc:7325 Review-Url: https://codereview.webrtc.org/2751063005 Cr-Commit-Position: refs/heads/master@{#17276}

Update voice_processing_audio_unit.mm

a971fd8

kAudioOutputUnitProperty_SetInputCallback for kAudioUnitScope_Global bus is 0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update voice_processing_audio_unit.mm#2

Update voice_processing_audio_unit.mm#2
liufeigit wants to merge 1 commit intopristineio:masterfrom
liufeigit:patch-1

liufeigit commented Jun 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

liufeigit commented Jun 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant