Skip to content

Conversation

@mbehzad
Copy link
Contributor

@mbehzad mbehzad commented Jun 25, 2024

== Description ==

This will re-enable the stylemark webpack plugin with an assemble instance (#91) which allows caching and creating dependency graph to only read, build, and write what is/will be changed.

This will increase the build time in watch mode from 20+ seconds to 1-2s

== Closes issue(s) ==

== Changes ==

== Affected Packages ==
assemble-lite
pv-stylemark

stylemark webpack plugin will use the assemble-lite instance which tracks handlerbar files dependecy
graph and cache the data to spped up build time

BREAKING CHANGE: there should be no breaking changes, but the amount of functionality changing is
high enough to have a major release note
@mbehzad
Copy link
Contributor Author

mbehzad commented Jun 25, 2024

if pull/240 is merged, it needs to be pulled into this branch and some small code updates also needs to be added.
also if the data files for pages/ (from issues/237) needs to be implemented, it makes sense to do it after that in this branch to prevent more merge conflicts

mbehzad added 4 commits July 2, 2024 17:40
this was removed in the new implementation of pv-stylemark (v4.)
… rendering the components

use same behaviour in assemble instance as the normal assemble, which uses data files in layout directory only for components
@mbehzad mbehzad force-pushed the feature/assemble-instance branch from 4312dc9 to 90a3a7d Compare July 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants