feat(pv-scripts): resolve paths to assets, relative to the scss file with the reference itself #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the reference itself instead of any asset reference in scss (url() for images, fonts etc) being resolved relative to the entry file. This allows sharing the same file between different entries / bundles. and improves IDE support (e.g. autocompletation, goto definition). (See https://www.npmjs.com/package/resolve-url-loader ) BREAKING CHANGE: Any relative paths being used in the scss file (e.g. `background-image: url(./path/to/sceleton.svg)`) which was previously relative to the entry file (e.g. index.scss) needs to be replaced with the relative path from the scss with the rule referencing the asset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Description ==
Instead of any asset reference in scss (url() for images, fonts etc) being resolved relative to the entry file. It will be resolved relative to the file itself. This allows sharing the same scss file between different entries / bundles. and improves IDE support (e.g. autocompletation, goto definition). (See https://www.npmjs.com/package/resolve-url-loader )
BREAKING CHANGE: Any relative paths being used in the scss file (e.g.
background-image: url(./path/to/sceleton.svg)) which was previously relative to the entry file (e.g. index.scss) needs to be replaced with the relative path from the scss with the rule referencing the asset.== Closes issue(s) ==
== Changes ==
== Affected Packages ==
pv-scripts