Open
Conversation
|
Just realize after today's meeting. I gusee the response time is the latency, say, the time to get the first byte. We may also want the response complete time, that is, the time to get the last byte. The response time should be compared with DHT walk duration, and the response complete should be compared with the total content fetch duration from an IPFS node. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields are already logged by nginx. We're just piping them through.
@iand quick questions:
refererfield is empty. Ishttp_refererthe wrong field here?addrfield contains cloudflare IP's and not client IP's. Should we rather userealip_remote_addrinstead ofremote_addrhere? Will pointed me to this line.upstream_cache_statusfield be populated innginx_conf_ipfs? If so, I'd love to add that there as well. I can also ask in thatbifrost-infrarepo 👍