LSP indexing parity: position snapping, DB persistence, workspace‑aware routing, and observability

.cargo/config.toml

@@ -1,9 +1,11 @@
 # Target-specific overrides for Windows MSVC
 [target.x86_64-pc-windows-msvc]
-rustflags = ["-C", "target-feature=+crt-static", "-C", "link-args=/DEBUG:NONE /NOLOGO"]
+# Increase stack size to 8MB to prevent stack overflow in CI environments with junction points
+rustflags = ["-C", "target-feature=+crt-static", "-C", "link-args=/DEBUG:NONE /NOLOGO /STACK:8388608"]
 
 [target.i686-pc-windows-msvc]
-rustflags = ["-C", "target-feature=+crt-static", "-C", "link-args=/DEBUG:NONE /NOLOGO"]
+# Increase stack size to 8MB to prevent stack overflow in CI environments with junction points
+rustflags = ["-C", "target-feature=+crt-static", "-C", "link-args=/DEBUG:NONE /NOLOGO /STACK:8388608"]
 
 # Configuration for Windows builds
 [target.'cfg(target_os = "windows")']

.githooks/pre-commit

@@ -1,4 +1,5 @@
 #!/bin/sh
+
 #
 # Pre-commit hook to run tests and code quality checks
 # Installed by 'make install-hooks'
@@ -9,6 +10,9 @@ GREEN='\033[0;32m'
 YELLOW='\033[0;33m'
 NC='\033[0m' # No Color
 
+# Always cleanup consent file after any commit attempt
+trap 'repo_root="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"; cd "$repo_root"; [ -f AGENT_CONSENT.md ] && [ -e .AGENT_CONSENT ] && rm -f .AGENT_CONSENT || true' EXIT
+
 echo "${YELLOW}Running pre-commit checks...${NC}"
 
 # Store the exit status of each command
@@ -27,8 +31,8 @@ rust_files_changed=$(git diff --cached --name-only | grep -E '\.(rs|toml)$|^Carg
 workflow_files_changed=$(git diff --cached --name-only | grep -E '^\.github/workflows/.*\.ya?ml$')
 
 if [ -z "$rust_files_changed" ] && [ -z "$workflow_files_changed" ]; then
-    echo "${YELLOW}No Rust or workflow files changed. Skipping checks.${NC}"
-    exit 0
+    echo "${YELLOW}No Rust or workflow files changed. Skipping Rust/workflow checks.${NC}"
+    # Don't exit here - we still need to run the consent check
 fi
 
 # Run actionlint if workflow files changed
@@ -91,9 +95,8 @@ if [ $status -eq 0 ]; then
 else
     echo "${RED}Pre-commit checks failed. Commit aborted.${NC}"
     echo "${YELLOW}You can bypass this check with 'git commit --no-verify'${NC}"
+    exit $status
 fi
 
-exit $status
-
 # Run Vow accountability check at the end
 "$(git config core.hooksPath)/pre-commit-vow"

.github/workflows/integration-test.yml

@@ -61,10 +61,10 @@
         key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-${{ hashFiles('rust-toolchain', 'rust-toolchain.toml') || 'stable' }}
         restore-keys: |
           ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-
           ${{ runner.os }}-cargo-
 
-    - name: Build Rust binary
-      run: cargo build --release
+    - name: Build Rust binary (debug mode for CI speed)
+      run: cargo build
 
     - name: Prepare npm package with local binary
       shell: bash
@@ -73,10 +73,11 @@
         mkdir -p npm/bin
 
         # Copy the built binary to npm package bin directory with correct naming
+        # On Unix, we need to preserve the Node.js wrapper script (probe) and put the binary as probe-binary
         if [[ "${{ runner.os }}" == "Windows" ]]; then
-          cp target/release/probe.exe npm/bin/probe.exe
+          cp target/debug/probe.exe npm/bin/probe.exe
         else
-          cp target/release/probe npm/bin/probe-binary
+          cp target/debug/probe npm/bin/probe-binary
           chmod +x npm/bin/probe-binary
         fi
 
@@ -409,8 +410,8 @@
           ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-
           ${{ runner.os }}-cargo-
 
-    - name: Build Rust binary
-      run: cargo build --release
+    - name: Build Rust binary (debug mode for CI speed)
+      run: cargo build
 
     - name: Build npm package
       run: |

.github/workflows/lsp-tests.yml

@@ -0,0 +1,144 @@
+name: LSP Tests
+
+on:
+  push:
+    branches: ["main"]
+  pull_request:
+    branches: ["main"]
+
+env:
+  CARGO_TERM_COLOR: always
+  CI: true
+
+jobs:
+  lsp-tests:
+    name: LSP Tests on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+        # Temporarily re-disable Windows - Big Brain's PATHEXT fix didn't fully resolve the issue
+        # Need to debug why typescript-language-server.cmd still not detected by Rust tests
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: stable
+          components: rustfmt, clippy
+
+      - name: Setup Rust cache
+        uses: actions/cache@v4
+        timeout-minutes: 5
+        with:
+          path: |
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            target/
+          key: ${{ runner.os }}-lsp-cargo-${{ hashFiles('**/Cargo.lock') }}-${{ hashFiles('rust-toolchain', 'rust-toolchain.toml') || 'stable' }}
+          restore-keys: |
+            ${{ runner.os }}-lsp-cargo-${{ hashFiles('**/Cargo.lock') }}-
+            ${{ runner.os }}-lsp-cargo-
+            ${{ runner.os }}-cargo-
+
+      - name: Install Go for LSP tests
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.21'
+
+      - name: Install gopls
+        run: go install golang.org/x/tools/gopls@latest
+
+      - name: Install Node.js for TypeScript/JavaScript LSP tests
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install TypeScript language server
+        run: |
+          npm install -g typescript-language-server typescript
+          echo "NPM global bin path: $(npm config get prefix)"
+
+      - name: Setup PHP for phpactor
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.1'
+          tools: composer
+
+      - name: Install phpactor (PHP language server)
+        run: |
+          composer global require phpactor/phpactor
+          echo "Composer global bin path: $(composer global config bin-dir --absolute)"
+          # Add composer global bin to PATH for the current job
+          composer global config bin-dir --absolute >> "$GITHUB_PATH"
+
+      - name: Show LSP tool versions
+        run: |
+          rustc --version
+          cargo --version
+          go version
+          gopls version
+          node --version
+          npm --version
+          typescript-language-server --version
+          php --version
+          composer --version
+          phpactor --version
+
+      - name: Build Rust project (includes LSP daemon library)
+        run: cargo build
+
+      - name: Run multi-workspace LSP tests
+        env:
+          PROBE_CI: 1
+        run: cargo test -p lsp-daemon --test integration_multi_workspace
+
+      - name: Run LSP integration tests
+        env:
+          PROBE_CI: 1
+        run: cargo test --test lsp_integration_tests
+
+      - name: Run comprehensive LSP tests
+        env:
+          DEBUG: 1
+          PROBE_CI: 1
+        shell: bash
+        run: |
+          echo "=== CI Environment Debug Info ==="
+          echo "CI=$CI"
+          echo "GITHUB_ACTIONS=$GITHUB_ACTIONS"
+          echo "RUNNER_OS=$RUNNER_OS"
+          echo "PATH=$PATH"
+          echo "=== Ensuring npm global binaries are in PATH ==="
+          if [ "$RUNNER_OS" = "Windows" ]; then
+            echo "Windows detected - adding npm global path to system PATH"
+            NPM_GLOBAL=$(npm config get prefix)
+            echo "NPM global prefix: $NPM_GLOBAL"
+            # Convert Windows path format and add to system PATH for test execution
+            NPM_GLOBAL_UNIX=$(cygpath -u "$NPM_GLOBAL" 2>/dev/null || echo "$NPM_GLOBAL")
+            export PATH="$NPM_GLOBAL_UNIX:$NPM_GLOBAL:$PATH"
+            echo "Updated PATH: $PATH"
+            # Also add to Windows system PATH for the test processes
+            echo "$NPM_GLOBAL" >> "$GITHUB_PATH"
+            echo "Added to GITHUB_PATH: $NPM_GLOBAL"
+          fi
+          echo "=== Ensuring composer global binaries are in PATH ==="
+          COMPOSER_BIN=$(composer global config bin-dir --absolute 2>/dev/null || echo "")
+          if [ -n "$COMPOSER_BIN" ] && [ -d "$COMPOSER_BIN" ]; then
+            echo "Composer global bin directory: $COMPOSER_BIN"
+            export PATH="$COMPOSER_BIN:$PATH"
+            echo "Updated PATH with composer: $PATH"
+          else
+            echo "Warning: Could not determine composer global bin directory"
+          fi
+          echo "=== Language Server Versions ==="
+          gopls version || echo "gopls version failed"
+          typescript-language-server --version || echo "typescript-language-server version failed"
+          phpactor --version || echo "phpactor version failed"
+          echo "=== Starting LSP comprehensive tests ==="
+          echo "NOTE: Running tests sequentially with --test-threads=1 to avoid race conditions"
+          cargo test --test lsp_comprehensive_tests -- --nocapture --test-threads=1

.github/workflows/rust-tests.yml

@@ -8,6 +8,7 @@
 
 env:
   CARGO_TERM_COLOR: always
+  CI: true
 
 jobs:
   check-changes:
@@ -87,7 +88,7 @@
             ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-
             ${{ runner.os }}-cargo-
 
-      - name: Show Rust version
+      - name: Show tool versions
         run: |
           rustc --version
           cargo --version
@@ -96,6 +97,13 @@
       - name: Check formatting
         run: cargo fmt --all -- --check
 
+      - name: Set custom target directory on Windows
+        if: runner.os == 'Windows'
+        run: |
+          echo "CARGO_TARGET_DIR=C:/probe-target" >> "$GITHUB_ENV"
+          mkdir -p C:/probe-target
+        shell: bash
+
       - name: Lint with clippy
         run: cargo clippy --all-targets --all-features -- -D warnings
 
@@ -108,11 +116,11 @@
       - name: Run integration tests
         run: cargo test --test integration_tests
 
       - name: Run property tests
         run: cargo test --test property_tests
 
-      - name: Run CLI tests
-        run: cargo test --test cli_tests
+      - name: Run CLI tests (Sequential on CI)
+        run: cargo test --test cli_tests -- --test-threads=1
 
   npm-tests:
     name: NPM Agent Tests on ${{ matrix.os }}

.gitignore

@@ -16,6 +16,9 @@ Cargo.lock
 # YAML files
 *.yml
 *.yaml
+# Exception for GitHub workflows
+!.github/workflows/*.yml
+!.github/workflows/*.yaml
 
 # Node.js specific ignores
 node_modules

.trigger-ci

@@ -0,0 +1 @@
+# Trigger CI run for experimental timing data collection