Conversation
Contributor
Author
|
I haven't quite worked out how to automatically trigger GitHub Actions CI, but here's the output from manually triggering on this branch: https://github.com/jamesmkrieger/ProDy/actions/runs/1087735002 This check passed. |
SHZ66
requested changes
Sep 30, 2021
| try: | ||
| heatmap.append(fromstring(items[-1], float, sep=';')) | ||
| except: | ||
| heatmap.append(frombuffer(items[-1], float, sep=';')) |
Collaborator
There was a problem hiding this comment.
These fixes might be too ad-hoc. There should be a better way to determine which function to use. In addition, it is better the catch the specific error than a general "except"
| self._labels[rows]) | ||
| except: | ||
| return Sequence(self._msa[rows, cols].tobytes(), | ||
| self._labels[rows]) |
Collaborator
There was a problem hiding this comment.
Same issue with these lines. Maybe use PY3K macro to check this?
Contributor
Author
There was a problem hiding this comment.
We have the following block in the Sequence object, on which we could maybe base these:
if PY3K:
try:
return self._array.tostring().decode()
except:
return self._array.tobytes().decode()
else:
return self._array.tostring()
Contributor
Author
There was a problem hiding this comment.
I've now tried this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have introduced some try/except blocks to account for things becoming deprecated. The relevant warnings came from pytest from Python 3.8 on Ubuntu 20.04 (Windows Subsystem for Linux 2):
I have accounted for a number of these but not all of them.