Closed
Conversation
Member
|
Thanks, @vbadwaj. We will wait for #1344 and @jamesmkrieger to review this PR. I made a draft release for 2.6.0 already, once this is merged I will publish it. |
jamesmkrieger
requested changes
Jul 18, 2025
Contributor
jamesmkrieger
left a comment
jamesmkrieger
left a comment
There was a problem hiding this comment.
There's a couple of things but otherwise this looks good
Member
|
Thanks, @jamesmkrieger. Also, @vbadwaj is adding in support for macos in the GitHub workflows so those tests run as well (to address #2048). |
Contributor
sounds good |
Contributor
|
I don't think the conda build instructions should go here. We want to keep the development install with pip as an option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing version numbers and general preparation for new prody release