Feat/FIB-1968 - Update profico eslint plugin so that we have import order for type imports#12
Closed
carloProfico wants to merge 3 commits intomainfrom
Conversation
- Implemented a new ESLint rule to enforce separation of type imports and value imports. - Added utility functions for categorizing and processing imports in . - Created test cases for valid and invalid import scenarios in . - Updated linter configuration to include the new type imports rule.
- Updated the import processing logic to handle absolute and relative imports with appropriate newline management. - Enhanced type import detection in utility functions to improve accuracy. - Added new type imports in test cases for better coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make a rule that will separate import type from import values, for example:
from this:
to this:
Also, this needs to work with the grouped imports rule to keep those imports in their groups (namespaces, absolute imports, relative imports)
I am not sure how this will work with the existing grouped imports plugin. I will be testing that, since I am now familiar with this repo, any suggestions are welcome.