Add option to prevent access to options early#213
Open
slickscreen wants to merge 7 commits intoproginosko:masterfrom
Open
Add option to prevent access to options early#213slickscreen wants to merge 7 commits intoproginosko:masterfrom
slickscreen wants to merge 7 commits intoproginosko:masterfrom
Conversation
e72face to
80442e6
Compare
This reverts commit 80442e6.
Author
|
As far as I can tell, this all works now. As with before, let me know if anything should be changed. |
|
I'm just a random passer-by, but: because you mentioned "Its easy to permanently lock an option set", maybe having some sort of password to access the settings early (you could give that password to a commitment buddy or whatever). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless you lock up the whole extension, there currently isn't a way to allow a set of sites without allowing that set to be edited.
This PR adds a way to lock option sets a certain amount of time before the set goes into effect.
It seems to work in its current state, but I'll be doing more testing later. let me know if you want anything changed.
Potential issues: