Feature/override selected block sets#673
Open
shipurjan wants to merge 4 commits intoproginosko:masterfrom
Open
Feature/override selected block sets#673shipurjan wants to merge 4 commits intoproginosko:masterfrom
shipurjan wants to merge 4 commits intoproginosko:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is a PR for a feature requested here (I needed it too)
#367
Basically it introduces the UI from Lockdown for Override, so that Override can be used for selected Sets and not only globally.
Use case:
I want to use LeechBlockNG to have some websites (defined 1 website per 1 block) blocked at all times, and only override them temporarily when I decide. But with current global override, it would give me access to all websites, not just 1 that I need. So with this solution it should work similar to Lockdown mode, but reversed.
Here are the test cases that I tested with this PR
UI State Persistence
Override Behavior
Edge Cases
Override Limit (if configured)