Update from very old GnuPG 1.4#49
Merged
proglottis merged 1 commit intoproglottis:masterfrom Nov 21, 2025
Merged
Conversation
The last release was 1.4.23 in Jun 2018; it's not very relevant in modern environments. More importantly, the unit tests have been consistently failing on macOS recently, and per proglottis#48 it seems that the underlying GnuPG does not provide the expected output, and updating GnuPG fixes that. We've been pinned to 1.x for ctx.SetCallback, but that feature now exists in 2.x as well, as long as callers opt in. So, do so. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This was referenced Nov 6, 2025
Open
Contributor
Author
|
I didn’t investigate the PowerPC test that tends to fail from time to time, but #43 contains a commit that might be relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last release was 1.4.23 in Jun 2018; it's not very relevant in modern environments.
More importantly, the unit tests have been consistently failing on macOS recently, and per #48 it seems that the underlying GnuPG does not provide the expected output, and updating GnuPG fixes that.
We've been pinned to 1.x for
ctx.SetCallback, but that feature now exists in 2.x as well, as long as callers opt in. So, do so.