Add included_keys filter (tests broken atm)#140
Open
h0jeZvgoxFepBQ2C wants to merge 2 commits intoprograils:masterfrom
Open
Add included_keys filter (tests broken atm)#140h0jeZvgoxFepBQ2C wants to merge 2 commits intoprograils:masterfrom
h0jeZvgoxFepBQ2C wants to merge 2 commits intoprograils:masterfrom
Conversation
h0jeZvgoxFepBQ2C
force-pushed
the
included_keys
branch
from
315b6ab to
e40a2bd
Compare
Member
|
Hi @h0jeZvgoxFepBQ2C , I'm back online, I'll take a look at this PR later this week. |
Member
|
@h0jeZvgoxFepBQ2C could you update PR with rebased master? |
h0jeZvgoxFepBQ2C
force-pushed
the
included_keys
branch
from
a1d4255 to
b56cb93
Compare
h0jeZvgoxFepBQ2C
force-pushed
the
included_keys
branch
from
b56cb93 to
386fe28
Compare
Contributor
Author
|
Rebased it again, would be cool if you could take a look, thanks! |
h0jeZvgoxFepBQ2C
force-pushed
the
included_keys
branch
from
386fe28 to
bc67a3b
Compare
Contributor
Author
|
I've rebased the PR, would be great if someone could take a look at it. |
mlitwiniuk
requested changes
Oct 19, 2020
Member
mlitwiniuk
left a comment
mlitwiniuk
left a comment
There was a problem hiding this comment.
@h0jeZvgoxFepBQ2C I think the only remark I have is how variable is called. What do you think?
| mattr_accessor :humanize_key | ||
| mattr_accessor :humanize_key_ignored_keys | ||
| mattr_accessor :humanize_key_ignored | ||
| mattr_accessor :included_keys |
Member
There was a problem hiding this comment.
I think that this variable name is misleading. How about only_accepted_keys ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a filter to only include specified keys (see #139).
If ignored_keys is specified too, it will search for keys which are included, but are not ignored.
Tests are not running through, but I don't understand why exactly.
It seems that
Lit.included_keysis not reset during test runs, even when the loader is set to nil?Do you maybe have an idea @mlitwiniuk ?