WIP: added code so decode always returns accuracyBonus even if 100k#68
Open
DanielJDufour wants to merge 1 commit intomasterfrom
Open
WIP: added code so decode always returns accuracyBonus even if 100k#68DanielJDufour wants to merge 1 commit intomasterfrom
DanielJDufour wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #29 .
I haven't tested toPoint on 100k MGRS strings, but my quick read through the code makes me thin this might change the result of toPoint for a 100k from the bottom left to the centroid. The centroid is now correct, but I want to make sure this change in functionality and results has a test case for it before requesting a new version is published.
If you want to use this functionality now, you can copy the mgrs.js file in the root directory. (I haven't run build, so dist/mgrs.js is the old version that is on NPM)