Fix Docker 29.x compatibility issues with Traefik - v1.4.2

[rquidute]

What Changed

Fixes Docker 29.x compatibility issues that cause Traefik proxy failures with "client version 1.24 is too old" errors. Implements automatic Docker version management to prevent compatibility issues during installation and updates.

Changes

• Fresh Installation Flow Updates:

  • Modified scripts/ubuntu/1-install-dependencies.sh to detect and exclude Docker 29.x versions during fresh installations
  • Added special handling for docker-ce packages to automatically install the latest Docker 28.x version
  • Implemented package holding to prevent automatic upgrades to incompatible versions

• Update Flow Integration:

  • Updated scripts/ubuntu/internal-auto-update.sh to include Docker compatibility check during system updates
  • Added call to fix-docker-compatibility.sh after stopping containers but before updating

• New Docker Fix Scripts (Workaround):

  • Created scripts/fix-docker-compatibility.sh: Core utility to detect Docker 29.x and downgrade to compatible 28.x versions
  • Created scripts/fix-docker-workaround.sh: Complete standalone solution that stops services, fixes Docker, rebuilds images, and restarts services

Related Issue

#812

Testing

The following scenarios were covered in this PR:

• Fresh install for v1.4.2 version, then run ./scripts/fix-docker-workaround.sh to workaround the issue
• Fresh install for v1.4.2 version, then update the workaround_docker_traefik_issue_v_1_4_2 branch version and issue was not there
• Fresh using workaround_docker_traefik_issue_v_1_4_2 branch and issue was not there

DO NOT MERGE SINCE IT'S STILL WAITING FOR THE CCB

[gemini-code-assist]

Summary of Changes

Hello @rquidute, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a comprehensive solution to address critical compatibility issues arising from Docker 29.x versions causing Traefik proxy failures. It introduces automated Docker version management across fresh installations and update flows, ensuring that the system always runs with a compatible Docker version. Additionally, it provides dedicated scripts for manual intervention and workaround scenarios, enhancing the overall stability and reliability of the environment.

Highlights

• Fresh Installation Compatibility: The installation script (1-install-dependencies.sh) has been updated to automatically detect and exclude Docker 29.x versions during fresh installations. It now installs the latest compatible Docker 28.x version and holds the packages to prevent future automatic upgrades to incompatible versions.
• Automated Update Compatibility: The internal auto-update script (internal-auto-update.sh) now includes a Docker compatibility check. It calls the new fix-docker-compatibility.sh script after stopping containers and before updating the main code, ensuring Docker remains compatible during system updates.
• New Docker Fix Scripts: Two new scripts have been added: fix-docker-compatibility.sh which is a core utility to detect Docker 29.x and downgrade to a compatible 28.x version, and fix-docker-workaround.sh which is a complete standalone solution that stops services, fixes Docker, rebuilds images, and restarts services.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a robust solution to address compatibility issues with Docker 29.x by automatically downgrading to a compatible 28.x version during installation and updates. The changes include new scripts for the compatibility fix and integrate them into the existing installation and update flows.

My review focuses on ensuring the new scripts are robust and consistent. I've identified a potential issue in 1-install-dependencies.sh where not all Docker-related packages are 'held', which could lead to unintended upgrades and re-introduce the compatibility problem. I've also suggested a minor improvement to a log message in fix-docker-compatibility.sh for better clarity. Overall, the changes are well-structured and effectively address the reported issue.