-
Notifications
You must be signed in to change notification settings - Fork 36
Fix Docker 29.x compatibility issues with Traefik - v1.5 #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.14+fall2025
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical compatibility issues between Docker 29.x and Traefik, which were causing proxy failures with 'client version is too old' errors. It implements a robust system for automatic Docker version management, ensuring that only compatible Docker 28.x versions are installed and maintained across both new setups and existing deployments. The changes include updates to installation and update scripts, alongside the introduction of dedicated scripts for detecting, downgrading, and holding Docker versions, providing a comprehensive solution to maintain operational stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a robust solution to handle Docker 29.x compatibility issues by adding scripts to detect and downgrade Docker when necessary. The changes are well-integrated into both fresh installation and update workflows. The new scripts are thoughtfully written, managing the downgrade process, including package removal, installation of a compatible version, and placing a hold on packages to prevent unwanted upgrades. The modifications to existing scripts correctly incorporate this new compatibility fix. My review includes a few minor suggestions to enhance code clarity and eliminate redundancy in the new shell scripts. Overall, the changes are excellent and effectively resolve the stated problem.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What Changed
Fixes Docker 29.x compatibility issues that cause Traefik proxy failures with "client version 1.24 is too old" errors. Implements automatic Docker version management to prevent compatibility issues during installation and updates.
Changes
Fresh Installation Flow Updates:
Update Flow Integration:
New Docker Fix Scripts (Workaround):
Related Issue
#812
Testing
The following scenarios were covered in this PR:
git checkout workaround_docker_traefik_issue_v_1_5
git pull
./scripts/ubuntu/auto-update.sh workaround_docker_traefik_issue_v_1_5and after updating the issue was not there.
workaround_docker_traefik_issue_v_1_5branch and issue was not thereDO NOT MERGE SINCE IT'S STILL WAITING FOR THE CCB