Skip to content

Conversation

@NewEditOfficial
Copy link

@NewEditOfficial NewEditOfficial commented Oct 11, 2022

Pull Request Description

This should allow use to handle phoneModal by our logic and it will resolve issue with hiding callModal (as for now)

  • Its way arround, even exports.npwd:setPhoneVisible(false) is failing to hide callPhoneModal.

Issue #894

Pull Request Checklist:

  • [Yes] Have you followed the guidelines in our Contributing document and Code of Conduct?
  • [Yes] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [Yes] Have you built and tested NPWD in-game after the relevant change?

feat (callModal): new export with option to handleCall modal
@NewEditOfficial
Copy link
Author

Any update? 👀

@itschip
Copy link
Member

itschip commented Oct 30, 2022

@NewEditOfficial You need to rebase this branch and resolve the conflicts.

@AvarianKnight AvarianKnight added the PR Conflicts Pull request has conflicts that need to be resolved. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Code Review Awaiting code review. Awaiting Testing Awaiting in-game testing. PR Conflicts Pull request has conflicts that need to be resolved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants