refactor: decouple designsystem data #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hyunjung-choi
approved these changes
Dec 5, 2025
Collaborator
hyunjung-choi
left a comment
hyunjung-choi
left a comment
There was a problem hiding this comment.
고생하셨습니다ㅠㅠㅠㅠㅠ
얘는 빨리 머지해야할 것 같네요 ! ㅎㅎ
Member
Author
|
검토 감사합니다! 바로 병합하겠습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
#21
디자인시스템 토큰을 사용할 때 자체적으로 주입하는 값과 머티리얼에 오버라이드하는 값을 섞어 사용하는 상황입니다.
What is the new behavior (if this is a feature change)?
디자인시스템 토큰을 사용할 때 자체적으로 주입하는 값만을 사용합니다.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes
LightAlertSuccess색상과DarkAlertSuccess색상을CommonAlertSuccess로 통일합니다.FeelinColors클래스를Theme.kt에서Colors.kt로 이동합니다.FeelinColors클래스가 디자인 시스템의 모든 색상 토큰을 가집니다.FeelinTypographyCollection을Type.kt에 추가합니다.FeelinTypography와LocalFeelinColors.current를 사용해야 합니다.Typography changes
MaterialTheme.typography.titleLarge→FeelinTypography.title1MaterialTheme.typography.titleMedium→FeelinTypography.title2MaterialTheme.typography.titleSmall→FeelinTypography.title3MaterialTheme.typography.headlineLarge→FeelinTypography.heading1MaterialTheme.typography.headlineSmall→FeelinTypography.heading3MaterialTheme.typography.bodyLarge→FeelinTypography.body1MaterialTheme.typography.bodyMedium→FeelinTypography.body2MaterialTheme.typography.bodySmall→FeelinTypography.body3MaterialTheme.typography.labelMedium→FeelinTypography.caption2MaterialTheme.typography.labelSmall→FeelinTypography.caption1CaptionActiveTextStyle→FeelinTypography.activeColor changes
MaterialTheme.colorScheme.primary→LocalFeelinColors.current.brandPrimaryMaterialTheme.colorScheme.primaryContainer→feelinColors.backgroundPrimaryOther information:
LabelMedium, LabelSmall 보니까 자체 디자인시스템 토큰 상수로 통일하기 잘 한거 같네요.