Skip to content

Feature/histImagTSfftw#209

Merged
nsoblath merged 2 commits intodevelopfrom
feature/histImagTS
Jan 30, 2026
Merged

Feature/histImagTSfftw#209
nsoblath merged 2 commits intodevelopfrom
feature/histImagTS

Conversation

@pslocum
Copy link
Contributor

@pslocum pslocum commented Mar 24, 2025

This is a change to fftw time series output histograms. Previously, only the real part of the time series was accessible in the basic-root-writer output after configuring:

@pslocum
Copy link
Contributor Author

pslocum commented Mar 24, 2025

Previously, using this signal-slot configuration:

"signal": "fft1:fft",
"slot": "writer:fs-fftw"

the basic-root-writer contained this histogram for time slice n:
histTSReal_n_0.

Now, using the same slot configuration, the basic-root-writer contains these histograms for time slice n:

histTSReal_n_0
histTSImag_n_0

return hist;
}

TH1D* KTTimeSeriesFFTW::CreateHistogramImag(const std::string& name) const
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the previous function be changed to CreateHistogramReal to maintain consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would provide consistency, but would require more changes upstream in the KTDAC class. So the benefit to the present approach is that it is a minimal addition that applies to one configuration. Another possibility would be to add a new function called CreateHistogramReal(), but without deleting the CreateHistogram() function that is in use by other classes.

Copy link
Member

@nsoblath nsoblath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as is.

@nsoblath nsoblath merged commit 544e75f into develop Jan 30, 2026
2 checks passed
@nsoblath nsoblath deleted the feature/histImagTS branch January 30, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants