This repository was archived by the owner on Mar 22, 2018. It is now read-only.
http-server should be specified under guestbookgo#72
Open
cdrage wants to merge 1 commit intoprojectatomic:masterfrom
Open
http-server should be specified under guestbookgo#72cdrage wants to merge 1 commit intoprojectatomic:masterfrom
cdrage wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Should conform to how k8s does it officially: https://github.com/kubernetes/kubernetes/blob/master/examples/guestbook-go/guestbook-service.json
Contributor
|
So I was the one that changed this. see 8aee829 Can you verify it is fixed in openshift now? Also should we consider postponing this fix until the fix has been out for a while. Otherwise people who try out this example on openshift are going to have issues without really knowing why. |
Member
Author
|
Ewww. It's not fixed :( That's sad. Will have to just keep this as is for now. |
Contributor
|
Well it is fixed. But it was just fixed not too long ago so we need to give some time for the industry to catch up :) - we could leave this open and say merge it in a couple of months? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should conform to how k8s does it officially:
https://github.com/kubernetes/kubernetes/blob/master/examples/guestbook-go/guestbook-service.json