Added support for SalamandraTA 7B instructed #10
Merged
carlosep93 merged 3 commits intoprojecte-aina:mainfrom Apr 22, 2025
Merged
Added support for SalamandraTA 7B instructed #10carlosep93 merged 3 commits intoprojecte-aina:mainfrom
carlosep93 merged 3 commits intoprojecte-aina:mainfrom
Conversation
jatserias
approved these changes
Apr 17, 2025
| is_model_loaded, is_tokenizer_loaded = False, False | ||
|
|
||
| def translator(src_texts, src, tgt): | ||
| print(lang_map) |
| def translator(src_texts, src, tgt): | ||
| print(lang_map) | ||
| if lang_map: | ||
| src = lang_map.get(src) if src in lang_map else src |
There was a problem hiding this comment.
question: do we want ot use the src value provided if not in the language map?
Contributor
Author
There was a problem hiding this comment.
I believe this part comes from the bilingual models. Without the source the API cannot choose the model to use.
| generated_text = tokenizer.decode(outputs[0, input_length:], skip_special_tokens=True) | ||
| return generated_text | ||
|
|
||
| return [salamandra_inst_translator(text, src, tgt, max_length=400) |
There was a problem hiding this comment.
question: what will be the src value if not langmap?
Contributor
Author
There was a problem hiding this comment.
By default it would be "es" (Spanish), if I'm not wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add support to the SalamadraTA 7B Instruct models. The main changes are:
How to run the API:
Where MULTI-MULTI-salamandra_instruct means: Multilingual source, Multilingual target and salamandra_instruct model type.
To send a request to the model: