feat: add support for building the "release" Prometheus from source #940
+115
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to compare Prometheus PR against anything in Prometheus repo or quay.io/prometheus/prometheus
It does change the default semantics when doing the typical
/prombench main. In the past it was taking the image with themaintag (while PR Prometheus always rebuild from source, from the latest git commit on the GitHub PR), now it builds from source for the givenstringthat can be git SHA, branch name or even PR number. Extra flagbench.use-registry=truehas to be added to force using docker image (previous behavior).Motivation
/prombench mainand realize you didn't rebase recently and a few commits are in the REF vs current PR. Even with recent rebase you will likely have a different commits as there's a lag betweenmaindocker tag and the latestmaincommit. We could autodetect the shared commit vs main or even merge with main and then benchmark in the next iteration.Next Steps