Skip to content

Fix #232: Only print modified file paths in fix command output #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serhan-Asad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #232: Only print modified file paths in fix command output #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 38 additions & 10 deletions pdd/fix_error_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,21 @@ def fix_error_loop(unit_test_file: str,
# Check if unit_test_file and code_file exist.
if not os.path.isfile(unit_test_file):
rprint(f"[red]Error:[/red] Unit test file '{unit_test_file}' does not exist.")
return False, "", "", 0, 0.0, ""
return False, "", "", 0, 0.0, "", False, False
if not os.path.isfile(code_file):
rprint(f"[red]Error:[/red] Code file '{code_file}' does not exist.")
return False, "", "", 0, 0.0, ""
return False, "", "", 0, 0.0, "", False, False

# Read original file contents at the START for modification detection (Issue #232)
try:
with open(unit_test_file, "r") as f:
original_test_content = f.read()
with open(code_file, "r") as f:
original_code_content = f.read()
except Exception as e:
rprint(f"[red]Error:[/red] Could not read original file contents: {e}")
return False, "", "", 0, 0.0, "", False, False

if verbose:
rprint("[cyan]Starting fix error loop process.[/cyan]")

Expand All @@ -325,7 +336,7 @@ def fix_error_loop(unit_test_file: str,
rprint(f"[green]Removed old error log file:[/green] {error_log_file}")
except Exception as e:
rprint(f"[red]Error:[/red] Could not remove error log file: {e}")
return False, "", "", 0, 0.0, ""
return False, "", "", 0, 0.0, "", False, False

# Initialize structured log
log_structure = {
Expand Down Expand Up @@ -401,7 +412,10 @@ def fix_error_loop(unit_test_file: str,
final_code = f.read()
except Exception:
pass
return success, final_unit_test, final_code, 1, agent_cost, agent_model
# Detect modifications by comparing with original content
test_modified = (final_unit_test != original_test_content) if final_unit_test else False
code_modified = (final_code != original_code_content) if final_code else False
return success, final_unit_test, final_code, 1, agent_cost, agent_model, test_modified, code_modified

verify_result = subprocess.run(verify_cmd, capture_output=True, text=True, shell=True, stdin=subprocess.DEVNULL)
pytest_output = (verify_result.stdout or "") + "\n" + (verify_result.stderr or "")
Expand Down Expand Up @@ -456,10 +470,13 @@ def fix_error_loop(unit_test_file: str,
final_code = f.read()
except Exception:
pass
return success, final_unit_test, final_code, 1, agent_cost, agent_model
# Detect modifications by comparing with original content
test_modified = (final_unit_test != original_test_content) if final_unit_test else False
code_modified = (final_code != original_code_content) if final_code else False
return success, final_unit_test, final_code, 1, agent_cost, agent_model, test_modified, code_modified
else:
# Agentic fallback disabled, return failure
return False, "", "", fix_attempts, total_cost, model_name
return False, "", "", fix_attempts, total_cost, model_name, False, False

# If target is not a Python file, trigger agentic fallback if tests fail
if not is_python:
Expand Down Expand Up @@ -496,7 +513,10 @@ def fix_error_loop(unit_test_file: str,
final_code = f.read()
except Exception:
pass
return success, final_unit_test, final_code, 1, agent_cost, agent_model
# Detect modifications by comparing with original content
test_modified = (final_unit_test != original_test_content) if final_unit_test else False
code_modified = (final_code != original_code_content) if final_code else False
return success, final_unit_test, final_code, 1, agent_cost, agent_model, test_modified, code_modified
else:
# Non-python tests passed, so we are successful.
rprint("[green]Non-Python tests passed. No fix needed.[/green]")
Expand All @@ -507,7 +527,8 @@ def fix_error_loop(unit_test_file: str,
final_code = f.read()
except Exception as e:
rprint(f"[yellow]Warning: Could not read final files: {e}[/yellow]")
return True, final_unit_test, final_code, 0, 0.0, "N/A"
# No modifications since tests already passed
return True, final_unit_test, final_code, 0, 0.0, "N/A", False, False

fails, errors, warnings = initial_fails, initial_errors, initial_warnings

Expand Down Expand Up @@ -916,7 +937,11 @@ def fix_error_loop(unit_test_file: str,
rprint(f"[yellow]Warning: Could not read files after successful agentic fix: {e}[/yellow]")
success = True

return success, final_unit_test, final_code, fix_attempts, total_cost, model_name
# Detect modifications by comparing with original content (Issue #232)
test_modified = (final_unit_test != original_test_content) if final_unit_test else False
code_modified = (final_code != original_code_content) if final_code else False

return success, final_unit_test, final_code, fix_attempts, total_cost, model_name, test_modified, code_modified

# If this module is run directly for testing purposes:
if __name__ == "__main__":
Expand All @@ -932,9 +957,10 @@ def fix_error_loop(unit_test_file: str,
error_log_file = "error_log.txt"
verbose = True

success, final_unit_test, final_code, attempts, total_cost, model_name = fix_error_loop(
success, final_unit_test, final_code, attempts, total_cost, model_name, test_modified, code_modified = fix_error_loop(
unit_test_file,
code_file,
"dummy_prompt.txt",
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line adds a new positional argument prompt_file between existing parameters code_file and prompt, which changes the function signature. However, the function definition shows prompt_file is already the 3rd parameter. This creates a duplicate argument, which will cause a TypeError when the function is called.

Suggested change
"dummy_prompt.txt",

Copilot uses AI. Check for mistakes.
prompt,
verification_program,
strength,
Expand All @@ -950,4 +976,6 @@ def fix_error_loop(unit_test_file: str,
rprint(f"Attempts: {attempts}")
rprint(f"Total cost: ${total_cost:.6f}")
rprint(f"Model used: {model_name}")
rprint(f"Test file modified: {test_modified}")
rprint(f"Code file modified: {code_modified}")
rprint(f"Final unit test contents:\n{final_unit_test}")
20 changes: 17 additions & 3 deletions pdd/fix_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def fix_main(
mode_desc = "hybrid (local tests + cloud LLM)" if use_cloud_for_loop else "local"
console.print(Panel(f"Performing {mode_desc} fix loop...", title="[blue]Mode[/blue]", expand=False))

success, fixed_unit_test, fixed_code, attempts, total_cost, model_name = fix_error_loop(
success, fixed_unit_test, fixed_code, attempts, total_cost, model_name, test_modified, code_modified = fix_error_loop(
unit_test_file=unit_test_file,
code_file=code_file,
prompt_file=prompt_file,
Expand Down Expand Up @@ -417,8 +417,22 @@ def fix_main(
rprint(f"[bold red]Error printing analysis preview: {e}[/bold red]")
if success:
rprint("[bold green]Fixed files saved:[/bold green]")
rprint(f" Test file: {output_file_paths['output_test']}")
rprint(f" Code file: {output_file_paths['output_code']}")

# Issue #232: Print file paths based on mode and modification/update flags
if loop:
# Loop mode: Only print files that were actually modified
if test_modified and fixed_unit_test:
rprint(f" Test file: {output_file_paths['output_test']}")
if code_modified and fixed_code:
rprint(f" Code file: {output_file_paths['output_code']}")
else:
# Non-loop mode: Print files where update flag is True AND content exists
if update_unit_test and fixed_unit_test:
rprint(f" Test file: {output_file_paths['output_test']}")
if update_code and fixed_code:
rprint(f" Code file: {output_file_paths['output_code']}")

# Always print results file if it exists
if output_file_paths.get("output_results"):
rprint(f" Results file: {output_file_paths['output_results']}")

Expand Down
Loading