Add failing tests for #493: update --output subdirectory crash

[Serhan-Asad]

Summary

Adds failing tests that detect the bug reported in #493.

Test Files

• Unit test: tests/test_update_main.py
• E2E test: tests/test_e2e_issue_493_update_output_subdir.py

What This PR Contains

• Failing unit test that reproduces the reported NameError
• Failing E2E test that verifies the bug at integration level
• Tests are verified to fail on current code and will pass once the bug is fixed

Root Cause

context_config is only defined in the else branch (line 75 of update_main.py) but used unconditionally at line 91 when the code file is in a subdirectory. Fix: initialize context_config = {} before the if/else block.

Next Steps

1. Implement the fix (add context_config = {} before the if/else block)
2. Verify the unit test passes
3. Verify the E2E test passes
4. Run full test suite
5. Mark PR as ready for review

Fixes #493

---

Generated by PDD agentic bug workflow

[Copilot]

Pull request overview

Adds regression coverage for issue #493 where pdd update --output crashes when the target code file lives in a subdirectory, and includes the minimal fix to prevent the context_config scoping error.

Changes:

• Add unit tests covering resolve_prompt_code_pair() with/without --output and with root/subdirectory code paths.
• Add an E2E regression test exercising update_main() with --output + subdirectory code file.
• Initialize context_config = {} before branching on output_dir to avoid UnboundLocalError.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
tests/test_update_main.py	Adds unit regression tests for resolve_prompt_code_pair() covering the reported crash scenario.
tests/test_e2e_issue_493_update_output_subdir.py	Adds an integration-level test to reproduce issue #493 via update_main() with --output.
pdd/update_main.py	Fixes scoping by initializing context_config before it’s used in subdirectory path logic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

os and pytest are imported but not used anywhere in this new test file. Please remove the unused imports to keep linting clean (and avoid failing CI if unused-import checks are enabled).

Suggested change

	import os
	import pytest

[Copilot]

The module docstring mixes NameError and UnboundLocalError. In Python, this specific case is UnboundLocalError (a subclass of NameError), but the wording should be consistent (prefer the precise exception name) to avoid confusion when someone is debugging failures.

[Copilot]

The module docstring mixes NameError and UnboundLocalError. In Python, this specific case is UnboundLocalError (a subclass of NameError), but the wording should be consistent (prefer the precise exception name) to avoid confusion when someone is debugging failures.

[Copilot]

This docstring is a bit too specific/brittle: (1) the exception is more precisely UnboundLocalError, and (2) referencing a hard-coded line number (“line 91”) will drift as the file changes. Consider describing the failure mode without line numbers (e.g., “used before assignment when output_dir is set”).

[Copilot]

The assertion str(output_dir) in prompt_path is a substring check and can be fragile across platforms/path normalization (e.g., case differences on Windows, differing separators). Prefer path-structure assertions using Path(prompt_path) (e.g., verify the prompt path is under output_dir via output_dir in Path(prompt_path).parents, or Path(prompt_path).resolve().is_relative_to(output_dir.resolve()) if available).