fix: budget tracker drops test costs due to tuple index bug#518
Open
Serhan-Asad wants to merge 1 commit intopromptdriven:mainfrom
Open
fix: budget tracker drops test costs due to tuple index bug#518Serhan-Asad wants to merge 1 commit intopromptdriven:mainfrom
Serhan-Asad wants to merge 1 commit intopromptdriven:mainfrom
Conversation
result[-2] on a 4-tuple returns model name string instead of cost float, silently dropping test/test_extend costs. Fixes promptdriven#508 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_orchestration.py:1752result[-2]on a 4-tuple returns model name string instead of cost float, silently dropping test/test_extend costsRoot Cause
result[-2]on(content, cost, model, agentic_success)returnsresult[2](model), notresult[1](cost). Theisinstance(..., (int, float))check fails silently, defaulting to$0.00.Fixes #508