Test normalize currents results in different fields #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jons-pf
reviewed
May 14, 2025
|
|
||
| def test_normalize_by_currents(makegrid_params: vmecpp.MakegridParameters): | ||
| makegrid_params.normalize_by_currents = True | ||
| response1 = vmecpp.MagneticFieldResponseTable.from_coils_file( |
Collaborator
There was a problem hiding this comment.
maybe call response1 and response2 something like response_normalized and response_unnormalized?
jons-pf
reviewed
May 14, 2025
|
|
||
|
|
||
| def test_normalize_by_currents(makegrid_params: vmecpp.MakegridParameters): | ||
| makegrid_params.normalize_by_currents = True |
Collaborator
There was a problem hiding this comment.
I think normalize_by_currents is misleading here - I chose a bad name - since we actually aim to normalize by the number of windings -> normalize_by_num_windings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.