Skip to content

Conversation

@jurasic-pf
Copy link
Collaborator

@jurasic-pf jurasic-pf commented Jul 10, 2025

Need to also update large tests to reflect the same for CI to pass. If approved, I'll do that.

Copy link
Collaborator Author

jurasic-pf commented Jul 10, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@jurasic-pf jurasic-pf force-pushed the jurasic/rename-enums branch from 3f7f1c2 to d594c1e Compare July 10, 2025 16:29
@jurasic-pf jurasic-pf force-pushed the jurasic/trace-unpreconditioned-forces branch from 3f70170 to d2bb3d4 Compare July 10, 2025 16:29
@jurasic-pf jurasic-pf marked this pull request as ready for review July 10, 2025 16:30
@jurasic-pf jurasic-pf requested a review from jons-pf July 10, 2025 16:30
@jurasic-pf jurasic-pf force-pushed the jurasic/trace-unpreconditioned-forces branch from d2bb3d4 to 9332c1c Compare July 10, 2025 16:35
@jurasic-pf jurasic-pf force-pushed the jurasic/rename-enums branch from d594c1e to 4713e77 Compare July 10, 2025 16:35
Copy link
Collaborator

jons-pf commented Jul 11, 2025

FYI, seems some related changes are required in vmecpp_large_cpp_tests - might need to keep some backwards-compatibility layer that keeps BAD_JACOBIAN etc, which then gets removed once the large cpp tests are updated

@jurasic-pf jurasic-pf force-pushed the jurasic/trace-unpreconditioned-forces branch from 9332c1c to b760990 Compare July 11, 2025 11:31
@jurasic-pf jurasic-pf force-pushed the jurasic/rename-enums branch 2 times, most recently from e6fa1c9 to 047c739 Compare July 11, 2025 11:31
@jurasic-pf jurasic-pf force-pushed the jurasic/trace-unpreconditioned-forces branch 2 times, most recently from 6e7ada4 to 0612687 Compare July 11, 2025 11:34
@jurasic-pf jurasic-pf force-pushed the jurasic/rename-enums branch 2 times, most recently from 2d2dcc8 to 6a59007 Compare July 11, 2025 11:35
@jurasic-pf jurasic-pf force-pushed the jurasic/trace-unpreconditioned-forces branch from 0612687 to 622f955 Compare July 11, 2025 11:35
@graphite-app graphite-app bot changed the base branch from jurasic/trace-unpreconditioned-forces to graphite-base/355 July 12, 2025 08:16
@graphite-app graphite-app bot force-pushed the graphite-base/355 branch from 622f955 to 21f1d7e Compare July 12, 2025 08:29
@graphite-app graphite-app bot force-pushed the jurasic/rename-enums branch from 6a59007 to 03625a4 Compare July 12, 2025 08:29
@graphite-app graphite-app bot changed the base branch from graphite-base/355 to main July 12, 2025 08:30
@graphite-app graphite-app bot force-pushed the jurasic/rename-enums branch from 03625a4 to 2f8f180 Compare July 12, 2025 08:30
@graphite-app
Copy link

graphite-app bot commented Sep 15, 2025

Merge activity

  • Sep 15, 11:37 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Sep 15, 11:37 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants