This repository was archived by the owner on Sep 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Hotfix/ppm 118 wireless backhaul sta mac #1586
Open
rmelotte
wants to merge
2
commits into
master
Choose a base branch
from
hotfix/ppm-118-wireless-backhaul-sta-mac
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -109,9 +109,13 @@ bool agent_ucc_listener::handle_dev_get_param(std::unordered_map<std::string, st | |||||
| auto ruid_str = tlvf::mac_to_string(std::strtoull(params["ruid"].c_str(), nullptr, 16)); | ||||||
| auto ruid = tlvf::mac_from_string(ruid_str); | ||||||
| if (params.find("ssid") == params.end()) { | ||||||
| // No ssid was given, return the radio MAC. | ||||||
| // We use MAC address as Radio UID, so we can just return it here. | ||||||
| value = ruid_str; | ||||||
| // No ssid was given, we need to return the backhaul sta mac. | ||||||
| if (!db->get_bsta_mac_by_ruid(ruid, mac_value)) { | ||||||
| LOG(ERROR) << " failed to find the backhaul sta MAC address for ruid '" << ruid_str; | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| value = "backhaul sta MAC not found for ruid '" + ruid_str + "'"; | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe not for this PR, but using output parameter for both the requested MAC address on success and for an error message on failure is a bad practice. |
||||||
| return false; | ||||||
| } | ||||||
| value = tlvf::mac_to_string(mac_value); | ||||||
| return true; | ||||||
| } | ||||||
| auto ssid = params["ssid"]; | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 399a33ca960cece195c3605d08951b8766e6c90d | ||
| 62af397ceba0f0c4d2e3ca19c66ca0a5d4ed1330 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.