fix(ollama): pull models on container creation #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull configured models when the container is created, rather than when the image is built. Otherwise they may be pulled as root and be inaccessible to the user.
prulloac
requested changes
Jan 6, 2025
| MIT License | ||
|
|
||
| Copyright (c) 2022 Microsoft Corporation | ||
| Copyright (c) 2024 Alex Fraser |
Owner
There was a problem hiding this comment.
please don't edit copyright license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull configured models when the container is created, rather than when the image is built. Otherwise they may be pulled as root and be inaccessible to the user.
📑 Description
install.shwrites the contents of PULL to/usr/local/share/ollama/models.txtinstall.shcreates/usr/local/share/ollama/pull.sh, which pulls each model specified inmodels.txtpull.sh.✅ Checks
ℹ️ Additional Information