-
Notifications
You must be signed in to change notification settings - Fork 18
Add JSON schema for rec_info output #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change representation of the ColorRGBAField in rec_info. BFW-8025
BFW-8025
Pass unnown fields as a raw CBOR hex string instead of the decoded CBOR representation. This should improve interoperability and opens the possibility of passing the unknown fields verbatim in the future without decoding them at all (not possible yet with the cbor library). BFW-8025
Silly variable name collision BFW-8025
Without UUID, the tag is still valid, just doesn't have an uuid. BFW-8025
- Change validate to produce a yaml report instead of asserting - Move things from opt_check that should be in validate (checks not tied to the field semantics) - If --opt-check is set, also do validation BFW-8025
82f017a to
a62d44e
Compare
ondratu
previously approved these changes
Dec 9, 2025
| @@ -1,6 +1,8 @@ | |||
| # Examples | |||
| The OpenPrintTag specification comes with [a set of utilities written in Python]({{repo}}/tree/main/utils) that serve as a baseline/reference implementation. | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nechceš to nějak sjednotit s tím dalším textemL Protože hned v dalším odstavci se píše, že rec_info je utilita která umí parsovat data z NFC....
ondratu
previously approved these changes
Dec 9, 2025
ljanecek
reviewed
Dec 10, 2025
ljanecek
previously approved these changes
Dec 10, 2025
hadrava
reviewed
Dec 10, 2025
hadrava
reviewed
Dec 10, 2025
ljanecek
approved these changes
Dec 11, 2025
This schema is intended to be used in other OpenPrintTag as well to provide a standardized decoded representation of data. BFW-8025
Also add a test case with colo BFW-8025
439d6da to
828951d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This schema is intended to be used in other OpenPrintTag as well to provide a standardized decoded representation of data.
BFW-8025