Skip to content

Conversation

@XAMPPRocky
Copy link
Contributor

This change makes so the casing for the category value is consistent between material_type_enum and main_fields. Also okay with changing it so main_fields is uppercase instead but I think this makes the most sense.

@CZDanol
Copy link
Collaborator

CZDanol commented Dec 14, 2025

Hello and thanks for your contribution :)

Hmm, there's nothing wrong with your PR, but material_type has been changed to a FFF-only field, so having the category field there does not make sense at this point.

I don't mind approving this, just thinking whether it would be better to remove the field altogether now.

@XAMPPRocky
Copy link
Contributor Author

Hmm, there's nothing wrong with your PR, but material_type has been changed to a FFF-only field, so having the category field there does not make sense at this point.

That is actually even better for me, as I was just about to make an issue about how currently the category is overloaded where tags_enum and material_type_enum both use category but they have two conflicting definitions of categories, making it harder to parse.

I'll make a follow up removing it.

@XAMPPRocky XAMPPRocky changed the title chore: set FFF in material_type_enum to lowercase chore: remove category field from material_type_enum Dec 14, 2025
@CZDanol
Copy link
Collaborator

CZDanol commented Dec 15, 2025

LGTM, thanks :) Feel free to merge

@XAMPPRocky
Copy link
Contributor Author

I can't merge? I don't have write permission to the repo 😄

@CZDanol
Copy link
Collaborator

CZDanol commented Dec 15, 2025

Oh, sorry :D

@CZDanol CZDanol merged commit 335e72a into prusa3d:main Dec 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants