Improve runtime checks on grid/domain validity#368
Merged
JamesMcClung merged 14 commits intomainfrom Nov 21, 2025
Merged
Conversation
germasch
approved these changes
Nov 21, 2025
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
👍
I've most definitely abused assert() way too much, and every so often it comes back to bite me (or you, I suppose) in release builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
LOG_ERRORinstead of assertions to enforce domain validity on release builds. None of these checks occur during the main loop—I assume—so there should be no real performance penalties.