Always attempt to assign coordinates when decoding#24
Merged
JamesMcClung merged 4 commits intopsc-code:mainfrom Apr 14, 2025
Merged
Always attempt to assign coordinates when decoding#24JamesMcClung merged 4 commits intopsc-code:mainfrom
JamesMcClung merged 4 commits intopsc-code:mainfrom
Conversation
before, even if length was present, it had to be manually passed to get coords
I don't like RET504 for 2 reasons: 1. naming quantities improves code readability 2. even if the variable isn't used now, it might be in the future, and the diff is nicer this way
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
germasch
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
lengthhad to be passed todecode_pscfor coordinates to be assigned, even if the dataset had a length attribute. Now,decode_pscwill always attempt to assign coordinates, and an error is thrown if no length (or corner) was given or present.Also, ignore RET504, which came up after the above change. I don't like RET504 for 2 reasons: