Assigning themes during package load #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
The issue is that themes were assigned at build time, which may become version incompatible or emit warnings during package build (which is how we spotted this issue). We advise against this in the following text:
https://ggplot2.tidyverse.org/articles/ggplot2-in-packages.html#creating-a-new-theme
This PR assigns themes on load instead of during build.
You can test your code with the development version of ggplot2 by installing it as follows:
We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time or let us know when ggplot2 should change. Hopefully this will inform you in a timely manner.
Best wishes,
Teun