Conversation
… test with rspec and make sure all cases pass
…ns to activity_insight_committee_job
…lidated DSL XML using Postman in AI beta environment.
Joao Vitor Barros da Silva (jvitorbarros15)
left a comment
Joao Vitor Barros da Silva (jvitorbarros15)
left a comment
There was a problem hiding this comment.
Nice workaround for the dates : )
Alex Kiessling (ajkiessl)
left a comment
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
I have a couple change requests and comments below:
| let(:xml_builder_obj) { described_class.new } | ||
|
|
||
| describe '#xmls_enumerator' do | ||
| it 'returns an xml of DSL records' do |
There was a problem hiding this comment.
We should test a faculty member that has no committees.
We should also test more than one faculty member that has committees, to make sure the batching works.
There was a problem hiding this comment.
It also wouldn't hurt to test a faculty member with more than one committee.
There was a problem hiding this comment.
Addes more tests for other edge cases.
| <DSL> | ||
| <ROLE>Mentor</ROLE> | ||
| <DSL_STUDENT> | ||
| <FNAME>Test</FNAME> | ||
| <LNAME>User</LNAME> | ||
| <DEG>PhD</DEG> | ||
| <TITLE>Test Title</TITLE> | ||
| </DSL_STUDENT> |
There was a problem hiding this comment.
We'll eventually need to add some more fields here. Like the end date, and others I can't remember right now. We can add those once we have the ETDA API up and running, though. I just want to make a note of it here.
…uploaded parameter from ActivityInsightCommitteeJob
|
usmannsiddiqui Our base ruby image stopped building properly. We fixed it in |
.gitignore
Outdated
| .bash_history | ||
| .envrc | ||
| .irb_history No newline at end of file | ||
| .irb_history.DS_Store |
There was a problem hiding this comment.
One last thing. The ".DS_Store" should be on a new line. The way this is now, it will might allow ".irb_history" and ".DS_Store" through separately.
4 participants
Closes #140