Update instead of copy excludes in updateDirectives.#36
Closed
skandel wants to merge 2 commits intopthrasher:masterfrom
Closed
Update instead of copy excludes in updateDirectives.#36skandel wants to merge 2 commits intopthrasher:masterfrom
skandel wants to merge 2 commits intopthrasher:masterfrom
Conversation
Owner
|
I've added this code to the 2.0.0 WIP release. #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateDirectives was creating a new excludes array each time the method was called, and the set of recursive calls to updateDirectives were not maintaining excludes across calls.