refactor: split rpc into actor/core/common layers#87
Open
Conversation
afterburn
force-pushed
the
refactor/arch
branch
4 times, most recently
from
7c12f32 to
b1985d3
Compare
afterburn
force-pushed
the
refactor/arch
branch
from
b1985d3 to
5f30c6d
Compare
86667
reviewed
Feb 19, 2026
86667
left a comment
86667
left a comment
There was a problem hiding this comment.
Nice refactor - much cleaner. A few small comments
|
Also some docs on running benchmarks in the README and in the |
86667
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the monolithic
rpcmodule into three layers:actor/- I/O orchestration (socket, tick loop, message dispatch)core/- core logic (iterative queries, put queries, server, routing maintenance, DHT statistics)common/closest_nodes- moved shared data structure out of rpcExtracted
RoutingMaintenanceandDhtStatisticsfrom inline logic in the rpc tick loop into their own modules.There are no public API changes and no performance regressions (benchmarked it using benchmarks in this repo and against
pubky-homeserver). Added 4 benchmarks for ongoing regression tracking.