feat(relay): Operation-based rate limiting + Resolve most recent#185
feat(relay): Operation-based rate limiting + Resolve most recent#185
Conversation
dbfd368 to
ed7d98b
Compare
SeverinAlexB
left a comment
There was a problem hiding this comment.
Need to do a second round later
|
@SeverinAlexB resolved your feedback:
|
SeverinAlexB
left a comment
There was a problem hiding this comment.
Two comments, otherwise looks good.
In the Pubky Core team, we have a convention on how to format PR title. We stick to the conventional commit format.
So for this PR, the title could be: feat(relay): Operation-based rate limiting + Resolve most recent
fb7d396 to
a1dbad2
Compare
|
SeverinAlexB
left a comment
There was a problem hiding this comment.
One NIT, otherwise good to go
|
Actually, should this add the |
SHAcollision
left a comment
There was a problem hiding this comment.
Great progress! Left a few minor comments and nits.
|
@SeverinAlexB @SHAcollision Restored DHT rate limiting that was previously removed. Since the DHT can be accessed directly, keeping rate limiting in place is necessary. The implementation is now fully backward compatible. Existing |
* Consolidate simple-dns dependency in workspace root * Bump simple-dns to latest 0.11.2 * Adapt calls to simple-dns methods * pkarr: fix port param lookup * extra: update Endpoint.params type Params type was updated to better match what simple-dns exposes. * Throw error if expected SVCParam type doesn't match * Simplify ipv4 parsing Co-authored-by: DZ <dzdidi@users.noreply.github.com> * Use static lifetine for SVCParam in Endpoint.params * fixed clippy * A few code cleanups * fmt --------- Co-authored-by: ok300 <106775972+ok300@users.noreply.github.com> Co-authored-by: DZ <dzdidi@users.noreply.github.com>
chore: release v6.0.0-rc.0
Summary
This PR replaces current rate limiting with an operation-based configuration that maps directly to the relay's three core operations:
publish,resolve, andresolve_most_recent.Configuration Example
Operations in this toml file automatically map to:
If no config.toml file is present, system will use defaults, so this is not a breaking change.