Merged
Conversation
afterburn
approved these changes
Feb 12, 2026
Contributor
afterburn
left a comment
There was a problem hiding this comment.
@SeverinAlexB lgtm, one small nit but feel free to ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1instead of0.0.0.0to fix 46 test failures on macOSTestnet::new_async(N)/Testnet::new(N)withTestnet::builder(N).build()(defaults to localhost).bind_address(Ipv4Addr::LOCALHOST)to all testDhtBuilderconfigsContext
On newer macOS, binding UDP sockets to
0.0.0.0causes DHT nodes to become unreachable — the OS may route UDP responses through a different interface than loopback, resulting inNoClosestNodesandUnexpectedResponseserrors. This caused 46 out of ~96 tests to fail.Mainline 6.1.1 added
Testnet::builder(N)which defaultsbind_addressto127.0.0.1(vs0.0.0.0in the legacynew()/new_async()constructors). This PR adopts that pattern across all pkarr tests, matching what mainline's own test suite does.Changes
pkarr/src/client/tests.rs: Replaced allTestnet::new_async()calls withTestnet::builder().build(), added.dht(|b| b.bind_address(Ipv4Addr::LOCALHOST))to the sharedbuilder()helper and standalone client builderspkarr/src/extra/endpoints/mod.rs: Same pattern for all 5 endpoint testsrelay/src/lib.rs: Addedbind_address(LOCALHOST)torun_test()andrun_testnet(), replacedTestnet::new()withTestnet::builder().build()See pubky/mainline#82