Closed
Conversation
Contributor
Author
|
Closing, the fix is not working as intended. Needs more research. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves a long standing legacy issue. On browsers (wasm), on signout, the cookies are not cleared.

What changed
pubky-sdk/bindings/js/pkg/tests/session.tsforsignoutnow must delete every per-user cookie from the environment. This test fails against the previous build, proving the bug and guarding the fix going forward.cookies::clear_session_cookieand called it fromSession::signout. The helper compiles only forwasm32and delegates to a tiny JS shim so both Node (viafetch-cookie's jar) and browsers (document.cookie) clear the exact cookie named after the user's public key. @86667 this might not work correctly jointly with Allow multiple cookies per user #262 right?scripts/patch.mjs) andnpm run build:testso wasm-bindgen's generatedsnippets/directory is treated like the rest of the runtime artifacts (copied alongsideindex.js, rewritten to use ESM imports) and no longer needs to be versioned.pkg/snippets/via.gitignoreso newly generated inline helpers do not get committed accidentally.