-
Notifications
You must be signed in to change notification settings - Fork 10
feat: big automations overhaul #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tefkah
wants to merge
120
commits into
main
Choose a base branch
from
tfk/conditions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f69eb7 to
1ec8212
Compare
|
53bfd76 to
c23cfe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
#1391
High-level Explanation of PR
This PR overhauls the entire actions system.
Rough outline
The event system for triggering automations (formerly rules) has also been revamped.
Instead of relying a lot on the app to communicate back and forth with
flockdirectly (or very indirectly), triggering of events has been simplified. We can roughly delineate 3 classes of eventsmanualandwebhookevents. there is no communication withflock, the app handles all the automation itself.automationSucceededandautomationFailedevents be triggered through some shady roundtrip toflockas before (basically "scheduling" the event to happen immediately), the database now immediately sends an event toflockonce an automation fails or succeeds.flockalso no longer sends these requests tocorewhich are roughly "hey a certain event triggered on a stage run all the automations that need to be run if any".flockis a lot dumber now, it just gets a payload which already includes the automation it needs to trigger, and just sends a request to core to do soPubEnteredandPubLeftevents are also like thisPubInStageForDuration, but acronevent would work the samePubEnterStagePubInStageForDurationautomation in that stage, if so it sends an event toflockto schedule an eventflocksends request tocoreto figure out the event schedulingcorecan eval)coresends request back toflockto run an automation in X amount of timeflocktriggers automation in coreSome other things this PR does:
core/prisma/consolidated-triggers.sqlTest Plan
Screenshots (if applicable)
Notes