Cmake #1
Open
Cmake #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a top level CMakeLists.txt
use FetchContent to get the required dependencies:
1. cpr (https://github.com/libcpr/cpr)
2. json (https://github.com/nlohmann/json)
replace "#pragma once" by proper include guards
rename variables "unix" to "_unix" to resolve some #define issue with
yet unknown origin
On branch cmake
Changes to be committed:
new file: .gitignore
new file: CMakeLists.txt
modified: cpp/base.cpp
modified: cpp/methods.cpp
new file: demo/yfdemo.cpp
modified: hpp/base.h
modified: hpp/benchmark.h
modified: hpp/methods.h
modified: hpp/requests.h
modified: hpp/structures.h
fix compiler warnings
fix some of the warnings emitted by gcc
puddup
approved these changes
Apr 9, 2024
Owner
|
Hi ofenloch, thanks for the improvements! : |
puddup
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, BloomShell,
I added CMake as build system and fixed some issues to build the project on Ubuntu 20.04 with gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2). Further, I added a running demo program (demo/yfdemo.cpp) using your code in the demo/*.cpp sources.
Regards
Oliver