Merged
Conversation
eliotjordan
force-pushed
the
update-tika
branch
from
e2a5639 to
69d085b
Compare
Member
|
@eliotjordan why do we update this way instead of pulling commits directly? |
Member
Author
|
@hackartisan We have customized the gem enough and were far behind the upstream enough that syncing was messy (rubocop being the primary cause). The better thing to do here is probably to submit a PR to the upstream gem to allow passing in a config file path. |
Member
Author
|
@hackartisan I made an upstream PR: mrcsparker#17 |
Member
|
Awesome!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from upstream