Skip to content

ci: Consolidate workflows and add pre-commit hooks#90

Merged
DanielKellerM merged 3 commits intomasterfrom
devel
Feb 20, 2026
Merged

ci: Consolidate workflows and add pre-commit hooks#90
DanielKellerM merged 3 commits intomasterfrom
devel

Conversation

@DanielKellerM
Copy link
Collaborator

@DanielKellerM DanielKellerM commented Feb 20, 2026

Summary

  • Workflow orchestrator: Add ci.yml that chains all CI workflows (lint, build, analyze, deploy, gitlab-ci) via workflow_call. Previously, each workflow triggered independently, meaning the internal GitLab CI would run even when lint checks were failing. Now workflows run as a ladder where each stage depends on the previous one, with lint as the first gate.
  • Fix flatdict dependency: Remove flatdict from requirements.txt and replace its usage in tracer.py with a simple recursive flatten. flatdict was causing CI failures due to install issues.
  • Pre-commit hooks: Add flake8 and yamllint hooks (matching CI config) plus gitlint for commit messages. Developers opt in with pre-commit install && pre-commit install --hook-type commit-msg.

@DanielKellerM DanielKellerM marked this pull request as ready for review February 20, 2026 13:57
Copilot AI review requested due to automatic review settings February 20, 2026 13:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request consolidates the CI pipeline into a single orchestrator workflow and adds pre-commit hooks for local development. The main changes introduce a workflow dependency chain to prevent expensive CI operations from running when early checks fail, remove a problematic Python dependency, and provide developers with optional local git hooks that match the CI configuration.

Changes:

  • Add ci.yml orchestrator that chains workflows (lint → build/analyze → gitlab-ci/deploy) to prevent GitLab CI from running when lint fails
  • Replace flatdict library with custom _flatten_dict function to fix CI installation issues
  • Add pre-commit hooks (.pre-commit-config.yaml and .gitlint) matching CI lint rules for optional local use

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/ci.yml New orchestrator workflow that chains lint, build, analyze, gitlab-ci, and deploy with proper dependencies
.github/workflows/lint.yml Changed triggers to workflow_call for orchestration support
.github/workflows/build.yml Changed triggers to workflow_call for orchestration support
.github/workflows/analyze.yml Changed triggers to workflow_call for orchestration support
.github/workflows/deploy.yml Changed triggers to workflow_call for orchestration support
.github/workflows/gitlab-ci.yml Changed triggers to workflow_call and added 200-minute timeout
.gitlab-ci.yml Migrated from deprecated except to rules syntax for branch filtering
util/mario/tracer.py Replaced flatdict.FlatDict with custom _flatten_dict implementation
requirements.txt Removed flatdict, added pre-commit
.pre-commit-config.yaml New pre-commit configuration with gitlint, flake8, and yamllint hooks
.gitlint New gitlint configuration matching CI commit message rules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DanielKellerM DanielKellerM merged commit f5b7617 into master Feb 20, 2026
31 checks passed
@DanielKellerM DanielKellerM deleted the devel branch February 20, 2026 16:23
github-actions bot pushed a commit that referenced this pull request Feb 20, 2026
* ci: Fix flatdict dependency

* ci: Chain workflows with workflow_call orchestrator

* ci: Add flake8 and yamllint pre-commit hooks
-----

Deployed from f5b7617
github-actions bot pushed a commit that referenced this pull request Feb 20, 2026
* ci: Fix flatdict dependency

* ci: Chain workflows with workflow_call orchestrator

* ci: Add flake8 and yamllint pre-commit hooks
-----

Deployed from f5b7617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants