Skip to content

Bender.yml: Move generated include dir into source group#304

Merged
colluca merged 1 commit intopulp-platform:mainfrom
fischeti:fix-bender-include-warning
Feb 21, 2026
Merged

Bender.yml: Move generated include dir into source group#304
colluca merged 1 commit intopulp-platform:mainfrom
fischeti:fix-bender-include-warning

Conversation

@fischeti
Copy link
Contributor

@fischeti fischeti commented Feb 18, 2026

Fixes a bender warning for non-existent include dirs. In my opinion hw/generated should not be a exported include dir, since snitch_cluster_wrapper is either generated in snitch_cluster itself behind a target (where I also added the include dir now), or it is generated externally (see picobello), where the include dirs anyway have to be specified manually.

@colluca colluca changed the base branch from develop to main February 19, 2026 09:27
@colluca colluca force-pushed the fix-bender-include-warning branch from 0735ac6 to 7b9e3b2 Compare February 19, 2026 09:28
@colluca colluca force-pushed the fix-bender-include-warning branch from 7b9e3b2 to e62c969 Compare February 21, 2026 13:22
@colluca colluca merged commit 0a18b1b into pulp-platform:main Feb 21, 2026
6 checks passed
colluca added a commit that referenced this pull request Feb 21, 2026
@colluca
Copy link
Collaborator

colluca commented Feb 21, 2026

Actually, it seems I rushed a bit too much with this one (should've gone through develop).

Compilation with QuestaSim breaks. Works with Verilator for some reason, which is why it wasn't catched in the Github CI.

The problem is that include_dirs is tied to the file group in which it is specified, not to the target (e.g. snitch_cluster_wrapper). And snitch_cluster_wrapper.sv is not the only generated file in hw/generated, snitch_cluster_addrmap.svh is too, which is giving error. So include_dirs has to be added to all file groups in which at least one file includes something from hw/generated.

As a matter of fact, now that I come to think about it better, I don't even think we need the include_dirs in the group containing snitch_cluster_wrapper.sv, since this file doesn't include anything.

I'm temporarily reverting this change, but we can readdress this in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants