Change default chmod behaviour, update xinetd dependency.#80
Open
nosmo wants to merge 4 commits intopuppetlabs:mainfrom
Open
Change default chmod behaviour, update xinetd dependency.#80nosmo wants to merge 4 commits intopuppetlabs:mainfrom
nosmo wants to merge 4 commits intopuppetlabs:mainfrom
Conversation
…etd, add required params
Contributor
|
I have a separate PR also dealing with chmod, but in a different manifest. We should make sure that they don't conflict (I think they should be okay?): |
Contributor
|
@nosmo , if you're still interested in getting this in, would you mind rebasing on master? |
Author
|
Rebased! |
Contributor
|
@nosmo I guess I'd rather see the defaults changed than dropping them altogether. Seems like these are defaults that a lot of people probably rely on. |
|
Hugh Nowlan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until after v3.0.7, rsync's chmod directives completely ignored octal chmods, only paying attention to "Du+rwx"-style specifiers. When upgrading from rsync v3.0.7 to v3.0.10, I hit an issue wherein rsynced directories became inaccessible because the 644 permissions are applied to all files and directories, and directories lacked executable bits. Rather than change this chmod to a comprehensive "Du+rwx,go+rx,Fu+rwx,go+r", I think it makes sense to disable the chmod by default and allow users to configure their own chmods per-module and otherwise maintain the original modes set on files.
This PR also updates the fixtures to use the now-puppetlabs-maintained xinetd repository and updates test facts accordingly.