Update Purescript versions in tests#42
Open
keijokapp wants to merge 1 commit intopurescript:masterfrom
Open
Conversation
Contributor
|
Can we instead bump those to The |
Author
|
Hi! I might be missing something here. If the goal is to test that the latest major PS versions work, the new test versions should be If the goal is to just test the installer itself then
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
0.13.0versions used in the tests does not work anymore due to dependency onlibtinfo. That makes the installer to try to build the binary from source. It might work for real use cases (though it failed in my Ubuntu 20.04 container) but the tests fail because of the time limit.I updated the versions in tests to the latest ones (
0.15.x). I also removed one test because I'm not able to see what the test is supposed to test and what version should be used there.