Tests - Package & Create Targets

[AdrianRomanski]

No description provided.

[AdrianRomanski]

This pull request bring the targets to 100% code coverage :)
Together with #69

[BioPhoton]

Suggested change

	* When you pass your own namedInputs (like you would in a project.json file) via the inferred tasks plugin,
	* the tasks pipeline ignores them and throws this error.
	* Some Nx plugins use the default namedInput, probably for that reason,
	* but I'm concerned that if developers change those inputs, it might lead to undesired behavior.
	* When you pass your own `namedInputs` (like you would in a `project.json` file) via the inferred tasks plugin,
	* the tasks pipeline ignores them and throws this error.
	* Some Nx plugins use the default `namedInput`, probably for that reason,
	* but I'm concerned that if developers change those inputs, it might lead to undesired behaviour.

I assume this situation changed since the discussion in #62 made progress.

[AdrianRomanski]

I have pushed the changes you suggested. Should i leave it in code if the situation changed?

[BioPhoton]

Another nice testing PR!! <3

Very nice you even checked the coverage 💪! I found slight things we could adjust... have a look.

[BioPhoton]

Any updates?

[AdrianRomanski]

I will push The changes today/tommorow

[AdrianRomanski]

Things done after review

1. Rephrasing docs, formatting
2. Change negations !boolean to is false
3. Change boolean to is true for consistency
4. Change not empty to given and empty to not given
5. Change configuration with correct structure to a config
6. Delete correct structure from other tests for consistency
7. Remove implementation details from docs
8. DependsOn checks - getPkgTargets()

Self Review

1. Delete duplicate test
2. Grouping tests by category and happy/unhappy path
3. Remove every const that were used once (Learned from Tests - Environment Targets #69)
4. Make generation tests check only one object at time or either whole structure
5. Delete correct structure from getPkgTargets() test names (consistency with create-targets)

[BioPhoton]

Suggested change

	expect(nxDevkitMockModule.logger.warn).toHaveBeenCalledTimes(0);
	});
	expect(nxDevkitMockModule.logger.warn).not.toHaveBeenCalled();
	});

[BioPhoton]

Suggested change

	expect(nxDevkitMockModule.logger.warn).toHaveBeenCalledTimes(0);
	});
	expect(nxDevkitMockModule.logger.warn).not.toHaveBeenCalled();
	});

[BioPhoton]

General best practices for setup spy's and configuring spy's:

• setup in describe
• configuring with potential defaults in beforeEach
• actual mock return in the it block

[BioPhoton]

Thanks for the tests!
I left some comments