Installer for Ubuntu

[ashwinikalokhe]

No description provided.

[codecov]

Codecov Report

Merging #2213 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage    70.5%   70.46%   -0.05%     
==========================================
  Files         148      148              
  Lines       23919    23919              
==========================================
- Hits        16865    16855      -10     
- Misses       7054     7064      +10

Impacted Files	Coverage Δ
src/rtFileDownloader.cpp	70.24% <0%> (-0.51%)	⬇️
examples/pxScene2d/src/pxResource.cpp	70.56% <0%> (-0.51%)	⬇️
examples/pxScene2d/src/pxScene2d.cpp	68.53% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e66c85...020fbd7. Read the comment docs.

[madanagopalt]

1, On output folder structure, can we keep the libs in a separate folder lib as we see in mac?
2, Are the files SparkEdge.ico and Spark.ico needed?. Is is used as part of ci?

CMakeLists.txt changes:

1, Move below lines inside glut flow, as it is the one applicable for desktop.
set(PXSCENE_LINKER_OPTIONS " /DEBUG ")
set(PXSCENE_INSTALLER 1)

2,Is it possible to use some other folder apart from /home folder, like /home/user , as some may not have permission on /home/Spark while generating tgz???

3,Below lines can be moved outside of rcvrcore installation out of duktape checks
install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/rcvrcore/" DESTINATION /home/Spark/rcvrcore COMPONENT pxscene) file(GLOB PXSCENE_INSTALL_FILES_JS "${CMAKE_CURRENT_SOURCE_DIR}/*.js")`

4, Remove below files from installation as those files are not present.
a, LICENSE.txt
b, folder named Release

5, Below rules may copy json files in further child directories also. Can we have filenames specified specifially or someway to ignore sub-directory files.
"${CMAKE_CURRENT_SOURCE_DIR}/*.json"
"${CMAKE_CURRENT_SOURCE_DIR}/*.conf"

6, Is below INSTALL_RPATH or RPATH?
SET(RPATH ${PXSCENE_LINK_LIBRARIES})

7, Avoid two entries for ${CMAKE_CURRENT_SOURCE_DIR}/linux/spark.sh and also, is it possible to reuse existing spark.sh with some args

8, Please keep absolute file names for .js files installed.

9, how to generate TGZ and what will be contents of tgz file?